<html><head>
</head>
<body><div>"<span style="font-family: monospace;">git submodule sync --recursive" did the trick.</span></div><div><br></div><div>I was on wolfssh 1.4.13. Now I'm back on 1.4.10 and 3.3.003-467-ge7f41bd8-dirty compiles.</div><div><br></div><div>Still "dirty" but it compiles.</div><div><br></div><div>Thanx!</div><div><br></div><div>Am Samstag, dem 13.05.2023 um 21:23 +0200 schrieb Ludovic LANGE:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div class="moz-cite-prefix">Indeed I was going to suggest that you pull fresh from master in another new dir in fact.</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">When doing so, you should have:</div><div class="moz-cite-prefix"> <ul> <li>"vehicle/OVMS.V3/components/wolfssh/wolfssh" as a submodule</li> <li>"vehicle/OVMS.V3/components/wolfssl/wolfssl" as a normal dir (for now. Will change in a few PR's)<br></li></ul><p>You can check that with : <br></p><pre>$ git submodule status
7b953e7ebb440ce9461ee469159c3759450e7c98 vehicle/OVMS.V3/components/mongoose/mongoose (6.2-882-g7b953e7)
c05f6c7530a8670e3d0ffdf04ee4cecb2d3b0496 vehicle/OVMS.V3/components/wolfssh/wolfssh (v1.4.10-stable)
7c3878f8302c0e84578a67473e49e60bc6b3ada7 vehicle/OVMS.V3/components/zip/libzip (rel-1-5-1-60-g7c3878f)
d6bcf4ca4d02479f058fff44cfd171f928148179 vehicle/OVMS.V3/components/zip/zlib (v1.2.11-65-gd6bcf4c)
</pre></div><div class="moz-cite-prefix">In particular, you should have wolfssh at v1.4.10-stable </div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">If not, please try both:</div><div class="moz-cite-prefix"><font face="monospace">git submodule update --init --recursive</font></div><div class="moz-cite-prefix"><font face="monospace">git submodule sync --recursive</font><br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">If not, please be sure that you do all this in a separate fresh directory.</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">If a new user tries to compile from scratch, I believe it should work. (I've just tried it, and it "works for me")</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">The error you have seems to imply that wolfssh is not at the proper 1.4.10 version but at a version >= 1.4.12<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Let us know.<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Regards,<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Le 13/05/2023 à 19:59, Chris van der Meijden a écrit :<br></div><div> <meta http-equiv="content-type" content="text/html; charset=UTF-8"></div><div>Could you please explain in detail what I need to do?</div><div><br></div><div>I tried to pull the code completely fresh from master. That does not work.</div><div><br></div><div>What if a new user tries to compile from scratch? Will they run into the same issues?</div><div><br></div><div><br></div><div><br></div><div>Am Samstag, dem 13.05.2023 um 19:32 +0200 schrieb Ludovic LANGE:</div><div> <br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div class="moz-cite-prefix">Hi Chris,</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Yes we unfortunately had an issue where we merged, then reverted a patch.</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">It seems that unfortunately it didn't work for you. Could you try to fetch, then reset your git repo to HEAD, it seems you did not fetch the "revert" patches ?</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Let us know.<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Le 13/05/2023 à 19:08, Chris van der Meijden a écrit :<br></div><div> <meta http-equiv="content-type" content="text/html;
charset=UTF-8"></div><div>Today I pulled the newest version. During the pull my Wolfssh directory was deleted. I then renewed all the submodules and I got the newest Wolfssh.</div><div><br></div><div>But now the verion 3.3.003-467-ge7f41bd8-dirty won't compile (why is it "dirty" anyways, I didn't change the code ...).</div><div><br></div><div>First I get</div><div><br></div><div>CXX build/console_ssh/src/console_ssh.o</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp: In function 'void wolfssh_logger(wolfSSH_LogLevel, const char*)':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp:1176:10: error: enumeration value 'WS_LOG_CERTMAN' not handled in switch [-Werror=switch]</div><div> switch (level)</div><div> ^</div><div><br></div><div>Then I add case WS_LOG_CERTMAN: on line 1178:</div><div><br></div><div>static void wolfssh_logger(enum wolfSSH_LogLevel level, const char* const msg)</div><div> {</div><div> switch (level)</div><div> {</div><div> case WS_LOG_CERTMAN:</div><div>...</div><div><br></div><div>But the I run into this error:</div><div><br></div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: In function 'IdentifyKey':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:883:9: warning: unused variable 'dynType' [-Wunused-variable]</div><div> int dynType = isPrivate ? DYNTYPE_PRIVKEY : DYNTYPE_PUBKEY;</div><div> ^</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: In function 'DoKexDhReply':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3947:17: error: implicit declaration of function 'PRIVATE_KEY_UNLOCK' [-Werror=implicit-function-declaration]</div><div> PRIVATE_KEY_UNLOCK();</div><div> ^</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3952:17: error: implicit declaration of function 'PRIVATE_KEY_LOCK' [-Werror=implicit-function-declaration]</div><div> PRIVATE_KEY_LOCK();</div><div> ^</div><div><br></div><div>Any ideas?</div><div><br></div><div>Regards Chris</div><div><br></div><div><span></span></div><div> <br> <fieldset class="moz-mime-attachment-header"></fieldset></div><pre>_______________________________________________</pre><pre>OvmsDev mailing list</pre><pre><a class="moz-txt-link-abbreviated moz-txt-link-freetext" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a></pre><pre><a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></pre><p><br></p><div>_______________________________________________<br></div><div>OvmsDev mailing list<br></div><div><a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true" class="moz-txt-link-freetext">OvmsDev@lists.openvehicles.com</a><br></div><div><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true" class="moz-txt-link-freetext">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br></div></blockquote><div><br></div><div><span></span></div><div> <br> <fieldset class="moz-mime-attachment-header"></fieldset></div><pre>_______________________________________________</pre><pre>OvmsDev mailing list</pre><pre><a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a></pre><pre><a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></pre><p><br></p><div id="grammalecte_menu_main_button_shadow_host" style="width:
0px; height: 0px;"><br></div><div>_______________________________________________<br></div><div>OvmsDev mailing list<br></div><div><a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br></div><div><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br></div></blockquote><div><br></div><div><span></span></div></body></html>