<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi list,</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">I started to split my big list of
      patches into smaller, more manageable, easier to review PRs:</div>
    <div class="moz-cite-prefix">
      <div class="moz-cite-prefix">
        <ul>
          <li> <a id="issue_825_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/825/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/825"
              data-turbo-frame="repo-content-turbo-frame">missing
              headers</a> <span class="opened-by">#825</span></li>
          <li> <a id="issue_824_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/824/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/824"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v5+:
              dependency on ovms_webserver.h</a> <span
              class="opened-by">#824</span></li>
          <li> <a id="issue_823_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/823/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/823"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v5+:
              change type of TaskHandle_t</a><span class="opened-by">
              #823</span></li>
          <li> <a id="issue_822_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/822/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/822"
              data-turbo-frame="repo-content-turbo-frame">changes to
              (long deprecated) ADC constants</a> <span
              class="opened-by">#822 </span> </li>
          <li> <a id="issue_821_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/821/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/821"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v5+:
              static assertion failed: std::vector must have the same
              value_type as its allocator</a> <span class="opened-by">#821
            </span> </li>
          <li> <a id="issue_820_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/820/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/820"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v5+:
              static assertion failed: comparison object must be
              invocable as const</a> <span class="opened-by">#820</span>
          </li>
          <li> <a id="issue_819_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/819/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/819"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v4+ :
              remove deprecated and unused esp_event_loop.h</a> <span
              class="opened-by">#819</span> </li>
          <li> <a id="issue_818_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/818/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/818"
              data-turbo-frame="repo-content-turbo-frame">remove warning
              by replacing rom/queue.h with sys/queue.h</a> <span
              class="opened-by">#818</span> </li>
          <li> <a id="issue_817_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/817/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/817"
              data-turbo-frame="repo-content-turbo-frame">remove warning
              : '_GNU_SOURCE' redefined</a> <span class="opened-by">#817</span>
          </li>
          <li> <a id="issue_816_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/816/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/816"
              data-turbo-frame="repo-content-turbo-frame">ESP-IDF v4+ :
              esp_intr.h is deprecated, replaced by esp_intr_alloc.h</a>
            <span class="opened-by">#816</span> </li>
          <li> <a id="issue_815_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/815/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/815"
              data-turbo-frame="repo-content-turbo-frame">Add header and
              fix function signature</a> <span class="opened-by">#815</span>
          </li>
          <li> <a id="issue_813_link" class="Link--primary
              v-align-middle no-underline h4 js-navigation-open
              markdown-title" data-hovercard-type="pull_request"
data-hovercard-url="/openvehicles/Open-Vehicle-Monitoring-System-3/pull/813/hovercard"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/813"
              data-turbo-frame="repo-content-turbo-frame">replace some
              constants with their more adapted counterpart</a> <span
              class="opened-by">#813 </span></li>
        </ul>
      </div>
    </div>
    <div class="moz-cite-prefix">Let me know if it's the proper approach
      ; and if some of you can review those changes and comment on them,
      it'll help merging those - and progress in reaching ESP-IDFv5
      compatibility.<br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Best regards,<br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Le 31/01/2023 à 01:49, Ludovic LANGE a
      écrit :<br>
    </div>
    <blockquote type="cite"
      cite="mid:c8a3790f-a00f-3760-2a7b-a1086cdcb992@lange.nom.fr">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <div class="moz-cite-prefix">Hi list,</div>
      <div class="moz-cite-prefix"><br>
      </div>
      <div class="moz-cite-prefix">Another quick post to share with you
        the progress on the ESP-IDFv5 + cmake endeavour:</div>
      <div class="moz-cite-prefix"><br>
      </div>
      <div class="moz-cite-prefix">
        <ul>
          <li>ESP-IDF v5 version of OVMSv3 is now officially booting and
            seems to work fine (then again, I'm not doing any real-world
            testing for lack of time / car at the moment - it's here
            that you can help me) with a few caveats detailed in the PR
            or <a moz-do-not-send="true"
href="https://github.com/llange/Open-Vehicle-Monitoring-System-3/blob/experimental-esp-idf-v5/README.md">the
              README.md</a>.<br>
            <br>
          </li>
          <li>The branch
            <a class="moz-txt-link-freetext"
href="https://github.com/llange/Open-Vehicle-Monitoring-System-3/tree/experimental-esp-idf-v5"
              moz-do-not-send="true">https://github.com/llange/Open-Vehicle-Monitoring-System-3/tree/experimental-esp-idf-v5</a>
            is now ready for testing, sharing, studying, ...<br>
            <br>
          </li>
          <li>I created a draft PR
            <a class="moz-txt-link-freetext"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/810"
              moz-do-not-send="true">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/810</a>
            (just like for ESP-IDFv4), in order to show the diff and
            gather feedback. Not to be merged as-is.<br>
            <br>
          </li>
          <li>I'll try to break it into smaller low-impact /
            easy-to-review PR's that could be merged as-is in current
            master (warning corrections, header definitions, xxprintf
            type impact, etc...), so that the big pieces could be more
            easily reviewed.<br>
          </li>
        </ul>
      </div>
      <div class="moz-cite-prefix"><br>
      </div>
      <div class="moz-cite-prefix">Please note that those branches / PRs
        are still Work-In-Progress, and that I may certainly (and
        wrongly) `push --force` some changes as I rebase, update or
        split the big PR into smaller, easy to study PRs. I'll try not
        to but can't promise :-)</div>
      <div class="moz-cite-prefix">So if you checkout the branch, please
        be warned and know your git commands to either reset or rebase
        your working copy...<br>
      </div>
      <div class="moz-cite-prefix"><br>
      </div>
      <div class="moz-cite-prefix">Next on my list are, in no particular
        order:</div>
      <div class="moz-cite-prefix">
        <ul>
          <li>Have a few patches/bugs fixed in upstream wolfSSL (in
            progress) in order to enable<br>
          </li>
          <li>Check to see if we could upgrade mongoose (not absolutely
            necessary because it works / compile OK with a small patch)</li>
          <li>Fix the remaining warnings</li>
          <ul>
            <li>And change the ADC implementation that is deprecated now</li>
            <li>deprecation of esp_vfs_fat_spiflash_mount /
              esp_vfs_fat_spiflash_unmount</li>
          </ul>
          <li>Fix the WIP WIP WIP commits</li>
          <li>Resume work on
            <a class="moz-txt-link-freetext"
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/issues/752"
              moz-do-not-send="true">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/issues/752</a><br>
          </li>
        </ul>
      </div>
      <div class="moz-cite-prefix"><br>
      </div>
      <div class="moz-cite-prefix">Boot time warnings to study and check
        if OK:</div>
      <div class="moz-cite-prefix">
        <ul>
          <li>W (1091) esp_psram: Virtual address not enough for PSRAM,
            map as much as we can. 4MB is mapped</li>
          <li>W (2132) ADC: legacy driver is deprecated, please migrate
            to `esp_adc/adc_oneshot.h`   (<- this one is easy to
            understand...)</li>
        </ul>
        <p><br>
        </p>
        <p>Additional instructions:</p>
        <p>When first building, your sdkconfig will be converted as some
          config options did change betwen ESP-IDF v3.x and v5.x.</p>
        <p>Run `menuconfig` and :</p>
        <ul>
          <li><b>Select FREERTOS_ENABLE_BACKWARD_COMPATIBILITY</b>(=y)
            "configENABLE_BACKWARD_COMPATIBILITY"</li>
          <li><b>Unselect MG_ENABLE_SSL</b>(=n) "Enable MONGOOSE SSL/TLS
            support"</li>
        </ul>
        <p><br>
        </p>
        <p>If any of you with some free time could be nice enough to try
          to reproduce such a build and share the experience here. Let
          me know how the instructions could be updated and what issues
          you are facing.<br>
        </p>
        <p><br>
        </p>
      </div>
      <div class="moz-cite-prefix">Best regards,</div>
    </blockquote>
    <br>
    <div id="grammalecte_menu_main_button_shadow_host" style="width:
      0px; height: 0px;"></div>
  </body>
</html>