<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Michael,<br>
<br>
adding unit conversion support to the shell and Duktape commands is
a good idea.<br>
<br>
Metrics are not meant to provide a user interface, they should be
defined to be efficient and non-redundant.<br>
<br>
Btw, metrics names also shall not use upper case characters, and
shall only use "." as a separator.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 05.11.22 um 11:22 schrieb Michael
Geddes:<br>
</div>
<blockquote type="cite"
cite="mid:CAH0p7uLCbfD_T5Pkt1V7iMC7HDR22dTUBwPbVLxsr-F4trZdyw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Hi all,<br>
<div>Some of the code I copied from Kona/Kia code had both
kwh/100km and km/kwh metrics in the code as 'Other'. </div>
<div>Adding the various power consumption Units is not
particularly hard (I will have a pull-request soon) - though
the conversions between them all required some thought!</div>
<div>... but it also made me think these two metrics that are
(with the consumption units added) defined like this: </div>
<div><font face="monospace">m_v_trip_consumption1 =
MyMetrics.InitFloat("xiq.v.trip.consumption.KWh/100km", 10,
0, kWHP100K);<br>
m_v_trip_consumption2 = MyMetrics.InitFloat("<a
href="http://xiq.v.trip.consumption.km/kWh"
moz-do-not-send="true">xiq.v.trip.consumption.km/kWh</a>",
10, 0, kPkWH);<br>
</font></div>
<div><br>
</div>
<div>These are effectively the same metric but in different
units!</div>
<div>I'm wondering if we would be better to have scripting and
Duktape support for converting metrics to different unit!
This might be also quite useful for those strange countries
that insist on using miles as a measurement.</div>
<div><br>
</div>
<div>On top of the 'metric list' and 'metric set' we could add a
'metric get' which gets a single value.. and add unit support
for get/set.</div>
<div><br>
</div>
<div>I've also got a pull request that improves the precision of
the km<->mi conversions and factors it out.</div>
<div><br>
</div>
<div>//.ichael</div>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</body>
</html>