<div dir="ltr"><div>Adding the separate sub-commands would be easy enough to add to this to force only temp or only volt. I had </div><div>contemplated it and it would be very easy given what I've already done.</div><div><br></div><div>I think from your screenshot, you would be ok with 4 + 1 cols too in that narrow arrangement.. so maybe I should just limit the display to 5 cols overall ?</div><div>imho I think that would be a lot better than what happens now with readings per module > 4! </div><div>Your Six modules would split into 2 lines of 3 in the current code.. would that be a problem?</div><div><br></div><div>For the ioniq 5, the info from the csv for torquepro shows a possible 192 cells, and it describes the temperatures as belonging to 'battery pack 1' through to 'battery pack 16', so I'm inclined to think that they have a temperature sensor there for pack 16? even though it would be empty in my car (180 cells filled).</div><div><br></div><div><br></div><div>//.ichael</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 1 Nov 2022 at 16:50, Michael Balzer <<a href="mailto:dexter@expeedo.de">dexter@expeedo.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
Michael,<br>
<br>
regarding separate temperature / voltage display, I suggest adding
sub commands, i.e. "bms temp" / "bms volt".<br>
<br>
Regarding the layout: it's difficult to tell what will fit,
especially in vertical orientation, as this depends on the display
and font size chosen. With a font size of 12.0 on my Huawei, max 4
columns would fit:<br>
<br>
<a href="https://drive.google.com/file/d/1ra6QWcPh03rd5GO9xyykY3ZI_ofRrzj1/view?usp=share_link" target="_blank">https://drive.google.com/file/d/1ra6QWcPh03rd5GO9xyykY3ZI_ofRrzj1/view?usp=share_link</a><br>
<a href="https://drive.google.com/file/d/1rasYOBL8lY1NwM9oq_gL6pvcX-uinJjj/view?usp=share_link" target="_blank">https://drive.google.com/file/d/1rasYOBL8lY1NwM9oq_gL6pvcX-uinJjj/view?usp=share_link</a><br>
<br>
Regarding your temperature sensors: it's possible you've actually
got <modules>+1 sensors if they are placed between the
modules. You should see that when heating up the battery by driving,
an empty/reserved module space wouldn't heat up as much as filled
modules. For a layout of temperature sensors between the cell
modules, you could decide to derive the module temperature by
building the average of it's adjacent sensors.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div>Am 01.11.22 um 09:19 schrieb Michael
Geddes:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div><font face="arial, sans-serif">Is there any reason I
shouldn't create a pull request for this?</font></div>
<div><font face="arial, sans-serif">At the moment a multiple of
5 (but not a multiple of 4) will give you 5 columns ..</font></div>
<div><font face="arial, sans-serif">though I suspect this won't
output nicely on the mobile app 'Messages' which really
will probably only work nicely with 4+1=5 total columns. </font></div>
<div><font face="arial, sans-serif"><br>
</font></div>
<div><font face="arial, sans-serif">This is my latest output</font></div>
<div><font face="arial, sans-serif">with </font></div>
<div><span style="font-family:arial,sans-serif">Voltage </span><font face="arial, sans-serif"><br>
</font></div>
<div><font face="arial, sans-serif"> Cells = 180 (of 192 max)</font></div>
<div><font face="arial, sans-serif"> Readings Per Module = 12
(so 15 modules of a possible 16)</font></div>
<div><font face="arial, sans-serif">Temperature</font></div>
<div><font face="arial, sans-serif"> Readings = 16</font></div>
<div><font face="arial, sans-serif"> Readings Per Module = 1</font></div>
<font size="1" face="monospace">
<div><br>
</div>
OVMS# bms<br>
Voltage:<br>
Average: 3.636V [3.620V - 3.640V]<br>
Deviation: SD 7.98mV [max 0.00mV], 0 warnings, 0 alerts<br>
Temperature:<br>
Average: 17.2C [ 17.0C - 18.0C]<br>
Deviation: SD 0.39C [max 0.39C], 0 warnings, 0 alerts<br>
Cells:<br>
+-----------------------------+--------+<br>
1 | 3.640V 3.640V 3.640V 3.640V | 18.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
2 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
3 | 3.640V 3.640V 3.640V 3.640V | 18.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
4 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.620V 3.640V | |<br>
+-----------------------------+--------+<br>
5 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
6 | 3.640V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
7 | 3.640V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.620V 3.620V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
8 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.620V 3.620V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
9 | 3.640V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.640V 3.620V 3.620V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
10 | 3.640V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.620V 3.620V 3.620V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
11 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.620V 3.640V 3.640V 3.640V | |<br>
| 3.620V 3.640V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
12 | 3.620V 3.640V 3.620V 3.620V | 17.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
13 | 3.620V 3.620V 3.640V 3.640V | 17.0C |<br>
| 3.620V 3.640V 3.640V 3.620V | |<br>
| 3.640V 3.620V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
14 | 3.620V 3.640V 3.640V 3.640V | 17.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.620V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
15 | 3.620V 3.640V 3.640V 3.640V | 18.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
16 | | 17.0C |<br>
+-----------------------------+--------+</font><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 1 Nov 2022 at 07:29,
Michael Geddes <<a href="mailto:frog@bunyip.wheelycreek.net" target="_blank">frog@bunyip.wheelycreek.net</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">.. As to whether this is correct for my i5: it
might actually be correct.<br>
<div>My i5 seems to have 180 of a possible 192 cells. It
seems that it's likely there are 12 cell packs in a
module (<a href="https://insideevs.com/news/539940/hyundai-ioniq5-battery-pack-opened/" target="_blank">https://insideevs.com/news/539940/hyundai-ioniq5-battery-pack-opened/</a>)</div>
<div>Which possibly means they still have a temperature
sensor for the unfilled module!? Which would make this
correct!</div>
<div>I wonder if I should cap the temperature sensors based
on the number of battery packs?</div>
<div>Anyway.</div>
<div>Should I try and reduce the height of that last module
entry?</div>
<div><br>
</div>
<div>//.ichael</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 1 Nov 2022 at
07:19, Michael Geddes <<a href="mailto:frog@bunyip.wheelycreek.net" target="_blank">frog@bunyip.wheelycreek.net</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Hi all,<br>
<div><br>
</div>
<div>I'll create a PR soon, but just wanted to ask
something first.</div>
<div><br>
</div>
<div>I've made the 'bms' command so that it will work
with temperature OR voltages and only display that one
column. For example:</div>
<div><font face="monospace">OVMS# bms<br>
Temperature:<br>
Average: 3.6C [ 3.6C - 3.6C]<br>
Deviation: SD 0.00C [max 0.48C], 0 warnings, 0
alerts<br>
Cells:<br>
+--------+<br>
1 | 14.0C |<br>
+--------+<br>
2 | 14.0C |<br>
+--------+<br>
3 | 14.0C |<br>
+--------+<br>
4 | 15.0C |<br>
+--------+<br>
5 | 14.0C |<br>
+--------+<br>
6 | 3.6C |<br>
+--------+<br>
7 | 3.6C |<br>
+--------+<br>
8 | 3.6C |<br>
+--------+<br>
9 | 3.6C |<br>
+--------+<br>
10 | 3.6C |<br>
+--------+<br>
11 | 3.6C |<br>
+--------+<br>
12 | 3.6C |<br>
+--------+<br>
13 | 3.6C |<br>
+--------+<br>
14 | 3.6C |<br>
+--------+<br>
15 | 3.6C |<br>
+--------+<br>
16 | 3.6C |<br>
+--------+</font><br>
</div>
<div>The other improvement I'm trying, and want some
feedback on is when you have readings-per-module set
> 4. Here I don't have it set quite right.. but you
get the idea. The setting is at 12, which ends up
being quite wide (yes, there's one temperature sensor
off on its own, so my setting is not quite right yet).</div>
<div>At the moment the column count is capped at 4 (and
will cope with it not dividing properly), but the idea
would be something along the lines of trying n % 3 and
n % 5 first and then 4. So cap the column count at 3,
5 or 4 depending. The idea is that this becomes
readable in the APP! </div>
<div>Thoughts?</div>
<div><br>
</div>
<div><font face="monospace">OVMS# bms<br>
Voltage:<br>
Average: 3.632V [3.620V - 3.640V]<br>
Deviation: SD 9.75mV [max 0.00mV], 0 warnings, 0
alerts<br>
Temperature:<br>
Average: 14.0C [ 13.0C - 15.0C]<br>
Deviation: SD 0.35C [max 0.48C], 0 warnings, 0
alerts<br>
Cells:<br>
+-----------------------------+--------+<br>
1 | 3.640V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
2 | 3.620V 3.620V 3.640V 3.640V | 14.0C |<br>
| 3.620V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
3 | 3.620V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
4 | 3.620V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
5 | 3.620V 3.620V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
6 | 3.640V 3.640V 3.640V 3.640V | 15.0C |<br>
| 3.640V 3.620V 3.620V 3.640V | |<br>
| 3.640V 3.620V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
7 | 3.640V 3.640V 3.640V 3.640V | 13.0C |<br>
| 3.620V 3.620V 3.620V 3.620V | |<br>
| 3.640V 3.640V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
8 | 3.620V 3.640V 3.620V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.620V 3.620V | |<br>
| 3.640V 3.640V 3.620V 3.620V | |<br>
+-----------------------------+--------+<br>
9 | 3.640V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.620V 3.620V 3.620V 3.620V | |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
10 | 3.620V 3.640V 3.640V 3.620V | 14.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
11 | 3.620V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.640V 3.640V | |<br>
| 3.620V 3.620V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
12 | 3.620V 3.620V 3.620V 3.620V | 14.0C |<br>
| 3.620V 3.620V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
13 | 3.620V 3.620V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.620V 3.620V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
14 | 3.620V 3.620V 3.640V 3.640V | 14.0C |<br>
| 3.620V 3.620V 3.620V 3.620V | |<br>
| 3.620V 3.620V 3.640V 3.620V | |<br>
+-----------------------------+--------+<br>
15 | 3.620V 3.640V 3.640V 3.640V | 14.0C |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
| 3.640V 3.640V 3.640V 3.640V | |<br>
+-----------------------------+--------+<br>
16 | | 14.0C |<br>
| | |<br>
| | |<br>
+-----------------------------+--------+<br>
OVMS#</font><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br>
OvmsDev mailing list<br>
<a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
</blockquote></div></div>