<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Well you learn something new every day! <div><br></div><div>So 1.3mv standard deviation is pretty good 😌 </div><div><br></div><div>Thanks for the clarification! And a bit of bed time reading ;-)<br><br><div dir="ltr"><span style="background-color: rgba(255, 255, 255, 0);">Regards</span><div><span style="background-color: rgba(255, 255, 255, 0);">Shane</span></div></div><div dir="ltr"><br><blockquote type="cite">On 5 Apr 2021, at 16:02, Michael Balzer <dexter@expeedo.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Shane,<br>
<br>
the standard deviation isn't the distance between the minimum and
maximum, it's a measure of variation from the mean value.<br>
<br>
Standard deviation is one of the main basic statistical analysis
tools. Read more on this on the web:
<a class="moz-txt-link-freetext" href="https://duckduckgo.com/?q=standard+deviation">https://duckduckgo.com/?q=standard+deviation</a><br>
<br>
In the battery chart, the standard deviation is shown as the
horizontal stripe with light blue background. The maximum standard
deviation observed since the last reset is shown by the two blue
lines.<br>
<br>
A high standard deviation, especially under load, means a high cell
drift = defective / aged / poorly selected pack.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 05.04.21 um 16:40 schrieb Shane @
Kilve Engineering:<br>
</div>
<blockquote type="cite" cite="mid:E86412E6-99D9-4E6C-B482-893281572156@kilve-engineering.co.uk">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Hi Michael look as the data below, ignoring there is some rounding
up done somewhere
<div class=""><br class="">
</div>
<div class="">Max 4.240</div>
<div class="">Min 4.200 </div>
<div class=""><br class="">
</div>
<div class="">That’s 40mv deviation</div>
<div class="">Stddev showing 4.35mv 0.00435 its one decimal place
out</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div class="">
Regards<br class="">
Shane </div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 5 Apr 2021, at 07:50, Michael Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<div class=""> Shane,<br class="">
<br class="">
what makes you think so?<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">Am 04.04.21 um 20:47
schrieb Shane @ Kilve Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:283E99E8-8237-44CB-9E11-68F9977B0EE7@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<span class="">Hi Michael, </span>
<div class=""><span class=""><br class="">
</span></div>
<div class=""><span class="">Me again</span></div>
<div class=""><span class="">It look like the bus
framework does the calc incorrect? </span></div>
<div class=""><span class="">Surly stddev should be
0.0435</span></div>
<div class=""><span class="">And stddev.max should be </span>0.0437147V </div>
<div class=""><span class=""><br class="">
</span></div>
<div class=""><span class="">v.b.p.voltage.avg
4.23496V </span>
<div class=""><span class="">v.b.p.voltage.grad
-0.00026V </span></div>
<div class=""><span class="">v.b.p.voltage.max
4.24V </span></div>
<div class=""><span class="">v.b.p.voltage.min 4.2V
<br class="Apple-interchange-newline">
v.b.p.voltage.stddev 0.00435V </span></div>
<div class=""><span class="">v.b.p.voltage.stddev.max
0.00437147V </span></div>
<div class="">
<div class=""><br class="">
</div>
<div class=""> Regards<br class="">
Shane </div>
<div class=""><br class="">
</div>
<div class=""><span id="cid:part1.2CA225C8.C7A9E7DD@expeedo.de"><Screenshot
2021-04-04 at 19.45.35.png></span></div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<blockquote type="cite" class="">
<div class="">On 4 Apr 2021, at 13:26, Michael
Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class=""> Shane,<br class="">
<br class="">
vector metrics in general can be set by
passing a vector or by using the element
setters provided (see API).<br class="">
<br class="">
But you don't need to set the cell
max/min/stddev metrics at all, you only
need to feed the cell voltages (and/or
temperatures). The BMS framework
automatically extracts all statistics
values from them.<br class="">
<br class="">
Btw, regarding your cell voltages:<br class="">
<br class="">
<blockquote type="cite" class="">
<div class=""><font class="" face="monospace">748[7c8]:e113 10 90
10 92 10 93 10 93 10 8e 10 92 10 8f
10 90 10 92 10 6c 10 93 10 93 10 8f
10 91 10 92 10 92 10 92 10 92 10 92
10 92 10 90 10 8e 10 90 10 92 10 8d
10 90 10 91 10 8f 10 8e 10 8f 10 91
10 90 10 90 10 91 10 8e 10 91 10 8e
10 91 10 90 10 8e 10 90 10 92 10 90
10 94 10 91 10 91 10 93 10 90 10 91
10 90 10 8f 10 93 10 92 10 8e 10 90
10 91 10 8b 10 92 10 90 10 91 10 8e
10 90 10 90 10 90 10 91 10 90 10 8f
10 90 10 90 10 8e 10 92 10 8e 10 91
10 89 10 91 10 91 10 91 10 8d 10 8f
10 8d 10 86 10 8a 10 8e 10 8f 10 91
10 90 10 92 10 94 10 88 10 8f 10 94
10 91 10 91 10 91 10 93 10 91 00 00
00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00</font></div>
</blockquote>
<br class="">
This looks like 96 cells with a factor of
0.001, e.g. 0x1090 = 4240 * 0.001 = 4.24V.<br class="">
<br class="">
Assuming you fix your IncomingPollReply()
handler to actually use the rxbuf string
and you copy the RXB_* macros from the
Ioniq VFL code, you can simply do this to
process the values:<br class="">
<br class="">
<font class="" face="monospace"> case
0xe113:<br class="">
{<br class="">
// Read battery cell voltages
1-96:<br class="">
BmsRestartCellVoltages();<br class="">
for (int i = 0; i < 96; i++) {<br class="">
BmsSetCellVoltage(i,
RXB_UINT16(i*2) * 0.001f);<br class="">
}<br class="">
break;<br class="">
}</font><br class="">
<br class="">
Doesn't look that hard, does it?<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">Am 04.04.21
um 12:37 schrieb Shane @ Kilve
Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:24927557-6566-4464-A9AF-E58DCB06C10E@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<span class="">morning peeps, sorry for
the newbie question whats different
about the cell vmax/vmin i see in
metrics_standard.h its a vector?</span><span class=""><br class="">
</span><span class="">(OvmsMetricVector<</span><span class="">float</span><span class="">>*
ms_v_bat_cell_vmax; // Cell
maximum voltages [V])</span><span class=""><br class="">
</span><span class="">does that mean i
have ot handle these different? if so
how?</span><span class=""><br class="">
</span><span class="">as all i get is
errors trying to setvalue to this
metric</span>
<div class=""><span class=""><br class="">
</span></div>
<div class="">
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.cpp:</b>
In member function '<b class="">void
OvmsVehicleMaxed3::IncomingBmsReply(canbus*, uint16_t, uint16_t,
uint8_t*, uint8_t, uint16_t)</b>':</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.cpp:159:82:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#b42419" class=""><b class="">error:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">no
matching function for call to '<b class="">OvmsMetricVector<float>::SetValue(float)</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
StandardMetrics.ms_v_bat_cell_vmax->SetValue((float)value2 / 1000);</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">
^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">In
file included from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle/vehicle.h:40:0</b>,</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.h:32</b>,</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.cpp:32</b>:</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:747:18:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">candidate:
bool OvmsMetricVector<ElemType,
Allocator>::SetValue(std::__cxx11::string) [with ElemType = float;
Allocator =
std::allocator<float>;
std::__cxx11::string =
std::__cxx11::basic_string<char>]</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
virtual bool SetValue(std::string
value)</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class=""> ^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:747:18:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class=""> no
known conversion for argument 1
from '<b class="">float</b>' to '<b class="">std::__cxx11::string
{aka
std::__cxx11::basic_string<char>}</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:763:10:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">candidate:
bool OvmsMetricVector<ElemType,
Allocator>::SetValue(const
std::vector<_Tp,
_Alloc>&, metric_unit_t)
[with ElemType = float; Allocator
= std::allocator<float>]</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
bool SetValue(const
std::vector<ElemType,
Allocator>& value,
metric_unit_t units = Other)</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class=""> ^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:763:10:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class=""> no
known conversion for argument 1
from '<b class="">float</b>' to '<b class="">const
std::vector<float,
std::allocator<float>
>&</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.cpp:162:82:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#b42419" class=""><b class="">error:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">no
matching function for call to '<b class="">OvmsMetricVector<float>::SetValue(float)</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
StandardMetrics.ms_v_bat_cell_vmin->SetValue((float)value2 / 1000);</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">
^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">In
file included from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle/vehicle.h:40:0</b>,</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.h:32</b>,</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
from <b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/components/vehicle_maxus_edeliver3/src/vehicle_med3.cpp:32</b>:</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:747:18:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">candidate:
bool OvmsMetricVector<ElemType,
Allocator>::SetValue(std::__cxx11::string) [with ElemType = float;
Allocator =
std::allocator<float>;
std::__cxx11::string =
std::__cxx11::basic_string<char>]</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
virtual bool SetValue(std::string
value)</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class=""> ^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:747:18:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class=""> no
known conversion for argument 1
from '<b class="">float</b>' to '<b class="">std::__cxx11::string
{aka
std::__cxx11::basic_string<char>}</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:763:10:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class="">candidate:
bool OvmsMetricVector<ElemType,
Allocator>::SetValue(const
std::vector<_Tp,
_Alloc>&, metric_unit_t)
[with ElemType = float; Allocator
= std::allocator<float>]</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">
bool SetValue(const
std::vector<ElemType,
Allocator>& value,
metric_unit_t units = Other)</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class=""> ^</b></span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><b class="">/Users/shane/Open-Vehicle-Monitoring-System-3-MGEV/vehicle/OVMS.V3/main/ovms_metrics.h:763:10:</b>
</span><span style="font-variant-ligatures:
no-common-ligatures; color:
#2eaebb" class=""><b class="">note:
</b></span><span style="font-variant-ligatures:
no-common-ligatures" class=""> no
known conversion for argument 1
from '<b class="">float</b>' to '<b class="">const
std::vector<float,
std::allocator<float>
>&</b>'</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">make[1]:
*** [src/vehicle_med3.o] Error 1</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">make:
***
[component-vehicle_maxus_edeliver3-build]
Error 2</span></div>
<div style="margin: 0px; font-stretch:
normal; font-size: 11px;
line-height: normal; font-family:
Menlo;" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">shane@Shanes-MacBook-Pro
OVMS.V3 % </span></div>
<div class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><br class="">
</span></div>
<br class="">
<div class=""> Regards<br class="">
Shane </div>
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 3 Apr 2021, at
12:02, Michael Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<div class=""> <font class="" face="monospace">OVMS# obd
can1 request device -t1000
7e4 7ec 2102<br class="">
7e4[7ec] 2102: Response:<br class="">
ff ff ff ff c4 c4 c4 c4 c4
c4 c4 c4 c4 c4 c4 c5 |
................<br class="">
c5 c4 c4 c4 c4 c4 c4 c4 c4
c4 c4 c4 c4 c4 c4 c4 |
................<br class="">
c4 c4 c4
c4
| .... <br class="">
<br class="">
OVMS# obd can1 request
device -t1000 7e4 7ec 2103<br class="">
7e4[7ec] 2103: Response:<br class="">
ff ff ff ff c4 c4 c4 c4 c4
c4 c4 c5 c5 c4 c4 c4 |
................<br class="">
c4 c4 c4 c4 c4 c5 c5 c5 c4
c5 c5 c5 c4 c5 c4 c4 |
................<br class="">
c5 c4 c4
c4
| .... <br class="">
<br class="">
OVMS# obd can1 request
device -t1000 7e4 7ec 2104<br class="">
7e4[7ec] 2104: Response:<br class="">
ff ff ff ff c4 c4 c5 c4 c4
c4 c4 c4 c4 c4 c4 c4 |
................<br class="">
c4 c4 c4 c4 c4 c4 c4 c4 c4
c4 c4 c4 c4 c4 c4 c4 |
................<br class="">
c4 c5 c4
c4
| .... </font><br class="">
<br class="">
<br class="">
Your voltages obviously are 16
bit values, so you'll need to
use RXB_UINT16() and multiply
your loop index by 2.<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">Am
03.04.21 um 12:04 schrieb
Shane @ Kilve Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:1B6E58C0-548B-4C5C-BF4D-DB1CA4FF9EA5@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
Hi has anyone got a sample
of the data for the cell
voltages on the ioniq vfl
just so I can see how the
macro is handling it? Or is
it played out the same as
below?
<div class=""><br class="">
<div class=""> Regards<br class="">
Shane </div>
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 29
Mar 2021, at 22:20,
Michael Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class="">
Shane,<br class="">
<br class="">
<div class="moz-cite-prefix">Am
29.03.21 um
20:17 schrieb
Shane @ Kilve
Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:C36B2385-C31B-4785-908C-248E5E9FE22E@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class="">can
any one tell
me what the
"v.e.c.login"
is and is it
need for
something to
work?</div>
</blockquote>
<br class="">
<table class="docutils" style="box-sizing: border-box; border-collapse: collapse;
border-spacing:
0px;
margin-bottom:
24px;
empty-cells:
show; border:
1px solid
rgb(225, 228,
229); color:
rgb(64, 64, 64);
font-family:
Lato,
proxima-nova,
"Helvetica
Neue",
Arial,
sans-serif;
font-size: 16px;
font-style:
normal;
font-variant-ligatures:
normal;
font-variant-caps:
normal;
font-weight:
400;
letter-spacing:
normal; orphans:
2; text-align:
start;
text-transform:
none;
white-space:
normal; widows:
2; word-spacing:
0px;
-webkit-text-stroke-width:
0px;
background-color:
rgb(252, 252,
252);
text-decoration-thickness:
initial;
text-decoration-style:
initial;
text-decoration-color:
initial;" border="1">
<tbody style="box-sizing:
border-box;" class="" valign="top">
<tr class="row-odd" style="box-sizing: border-box;">
<td style="box-sizing:
border-box;
vertical-align:
middle;
white-space:
normal
!important;
font-size:
14.4px;
margin: 0px;
overflow:
visible;
padding: 8px
16px;
background-color:
transparent;
border-bottom:
1px solid
rgb(225, 228,
229);
border-left:
0px solid
rgb(225, 228,
229);" class="">v.e.c.config</td>
<td style="box-sizing:
border-box;
vertical-align:
middle;
white-space:
normal
!important;
font-size:
14.4px;
margin: 0px;
overflow:
visible;
padding: 8px
16px;
background-color:
transparent;
border-bottom:
1px solid
rgb(225, 228,
229);
border-left:
1px solid
rgb(225, 228,
229);" class=""> </td>
<td style="box-sizing:
border-box;
vertical-align:
middle;
white-space:
normal
!important;
font-size:
14.4px;
margin: 0px;
overflow:
visible;
padding: 8px
16px;
background-color:
transparent;
border-bottom:
1px solid
rgb(225, 228,
229);
border-left:
1px solid
rgb(225, 228,
229);" class="">yes =
ECU/controller
in
configuration
state</td>
</tr>
</tbody>
</table>
It's not used by
the framework
currently.<br class="">
<br class="">
<blockquote type="cite" cite="mid:C36B2385-C31B-4785-908C-248E5E9FE22E@kilve-engineering.co.uk" class="">
<div class="">also
any one with
any ideas how
to deal with
cell voltages
in a string
this long?
took me
blumim ages to
find the bms
when the tx
and rx are 128
address
apart!!</div>
<div class=""><br class="">
</div>
<div class="">748[7c8]:e113
10 90 10 92 10
93 10 93 10 8e
10 92 10 8f 10
90 10 92 10 6c
10 93 10 93 10
8f 10 91 10 92
10 92 10 92 10
92 10 92 10 92
10 90 10 8e 10
90 10 92 10 8d
10 90 10 91 10
8f 10 8e 10 8f
10 91 10 90 10
90 10 91 10 8e
10 91 10 8e 10
91 10 90 10 8e
10 90 10 92 10
90 10 94 10 91
10 91 10 93 10
90 10 91 10 90
10 8f 10 93 10
92 10 8e 10 90
10 91 10 8b 10
92 10 90 10 91
10 8e 10 90 10
90 10 90 10 91
10 90 10 8f 10
90 10 90 10 8e
10 92 10 8e 10
91 10 89 10 91
10 91 10 91 10
8d 10 8f 10 8d
10 86 10 8a 10
8e 10 8f 10 91
10 90 10 92 10
94 10 88 10 8f
10 94 10 91 10
91 10 91 10 93
10 91 00 00 00
00 00 00 00 00
00 00 00 00 00
00 00 00 00 00
00 00 00 00 00
00 00 00 00 00
00 00 00 00</div>
</blockquote>
<br class="">
Simply loop over
the cells
contained. Have a
look at the buffer
macro utils, e.g.:<br class="">
<a class="moz-txt-link-freetext" href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_hyundai_ioniqvfl/src/vehicle_hyundai_ioniqvfl.cpp#L44" moz-do-not-send="true">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_hyundai_ioniqvfl/src/vehicle_hyundai_ioniqvfl.cpp#L44</a><br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<blockquote type="cite" cite="mid:C36B2385-C31B-4785-908C-248E5E9FE22E@kilve-engineering.co.uk" class="">Shane
<div class=""><br class="">
<br class="">
</div>
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On
5 Mar 2021, at
20:45, Michael
Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class="">
Shane,<br class="">
<br class="">
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
OvmsVehicle::PollSetPidList(m_can1,
obdii_polls);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
OvmsVehicle::PollSetState(<span style="color:
#1c00cf" class="">0</span>);</div>
<br class="">
needs to be
done in your
vehicle init,
i.e. the
constructor
after
RegisterCanBus().<br class="">
<br class="">
Please read
the
vehicle_obdii
module source
for a complete
polling
example.<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">Am
05.03.21 um
17:59 schrieb
Shane @ Kilve
Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:C4E964B9-5B75-44E1-A613-AE463CC9DC48@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
Thanks
Michael,
<div class=""><br class="">
</div>
<div class="">Had
a try and
ended up with
this bit added
but return
anything</div>
<div class=""><br class="">
</div>
<div class="">Where
am I going
wrong?</div>
<div class=""><br class="">
</div>
<div class="">
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class="">Shane</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class="">*******</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(196, 26,
22);
background-color:
rgb(255, 255,
255);" class=""><span style="color:
#643820" class="">#include
</span>"ovms_log.h"</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(155, 35,
147);
background-color:
rgb(255, 255,
255);" class=""><b class="">static</b><span style="" class=""> </span><b class="">const</b><span style="" class=""> </span><b class="">char</b><span style="" class=""> *</span><span style="color:
#0f68a0" class="">TAG</span><span style="" class=""> = </span><span style="color:
#c41a16" class="">"v-edeliver3"</span><span style="" class="">;</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(196, 26,
22);
background-color:
rgb(255, 255,
255);" class=""><span style="color:
#643820" class="">#include
</span>"vehicle_edeliver3.h"</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(196, 26,
22);
background-color:
rgb(255, 255,
255);" class=""><span style="color:
#643820" class="">#include
</span>"metrics_standard.h"</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(155, 35,
147);
background-color:
rgb(255, 255,
255);" class=""><b class="">namespace</b><span style="" class=""> {</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(15, 104,
160);
background-color:
rgb(255, 255,
255);" class=""><span style="color:
#9b2393" class=""><b class="">const</b></span><span style="" class=""> </span>OvmsVehicle<span style="" class="">::</span>poll_pid_t<span style="" class=""> </span>obdii_polls<span style="" class="">[] =</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">{</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> {
<span style="color:
#1c00cf" class="">0x7e3</span>,
<span style="color:
#1c00cf" class="">0x7eb</span>,
VEHICLE_POLL_TYPE_OBDIIEXTENDED, <span style="color: #1c00cf" class="">0xf194</span>,
{ <span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>
}, <span style="color:
#1c00cf" class="">0</span>,
ISOTP_STD }, <span style="color:
#5d6c79" class="">//VIN</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> {
<span style="color:
#1c00cf" class="">0x7e3</span>,
<span style="color:
#1c00cf" class="">0x7eb</span>,
VEHICLE_POLL_TYPE_OBDIIEXTENDED, <span style="color: #1c00cf" class="">0xe003</span>,
{ <span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>,
<span style="color:
#1c00cf" class="">10</span>
}, <span style="color:
#1c00cf" class="">0</span>,
ISOTP_STD }, <span style="color:
#5d6c79" class="">//SOH</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
POLL_LIST_END</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">};</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">};</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(15, 104,
160);
background-color:
rgb(255, 255,
255);" class="">OvmsVehicleEdeliver3<span style="" class="">::</span>OvmsVehicleEdeliver3<span style="" class="">()</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> {</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(196, 26,
22);
background-color:
rgb(255, 255,
255);" class=""><span style="" class="">
ESP_LOGI(TAG,
</span>"Start
eDeliver3
vehicle
module"<span style="" class="">);</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class="">
<br class="webkit-block-placeholder">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
RegisterCanBus(<span style="color: #1c00cf" class="">1</span>,CAN_MODE_ACTIVE,CAN_SPEED_500KBPS);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> }</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(15, 104,
160);
background-color:
rgb(255, 255,
255);" class="">OvmsVehicleEdeliver3<span style="" class="">::~</span>OvmsVehicleEdeliver3<span style="" class="">()</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> {</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(196, 26,
22);
background-color:
rgb(255, 255,
255);" class=""><span style="" class="">
ESP_LOGI(TAG,
</span>"Stop
eDeliver3
vehicle
module"<span style="" class="">);</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class="">
<br class="webkit-block-placeholder">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
memset(m_vin,
<span style="color:
#1c00cf" class="">0</span>,
<span style="color:
#9b2393" class=""><b class="">sizeof</b></span>(m_vin));</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> }</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(93, 108,
121);
background-color:
rgb(255, 255,
255);" class="">//testing
polls</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(15, 104,
160);
background-color:
rgb(255, 255,
255);" class=""><span style="color:
#9b2393" class=""><b class="">void</b></span><span style="" class=""> </span>OvmsVehicleEdeliver3<span style="" class="">::</span>IncomingPollReply<span style="" class="">(</span></div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
canbus* bus,
uint16_t type,
uint16_t pid,
uint8_t* data,
uint8_t
length,
uint16_t
mlremain)</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">{</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
string&
rxbuf =
med_obd_rxbuf;</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""> <br class="webkit-block-placeholder">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
OvmsVehicle::PollSetPidList(m_can1,
obdii_polls);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
OvmsVehicle::PollSetState(<span style="color:
#1c00cf" class="">0</span>);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""> <br class="webkit-block-placeholder">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(93, 108,
121);
background-color:
rgb(255, 255,
255);" class=""><span style="" class=""> </span>//
init / fill rx
buffer:</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> <span style="color:
#9b2393" class=""><b class="">if</b></span>
(m_poll_ml_frame == <span style="color: #1c00cf" class="">0</span>) {</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
rxbuf.clear();</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
rxbuf.reserve(length + mlremain);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> }</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
rxbuf.append((<span style="color:
#9b2393" class=""><b class="">char</b></span>*)data,
length);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> <span style="color:
#9b2393" class=""><b class="">if</b></span>
(mlremain)</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
<span style="color:
#9b2393" class=""><b class="">return</b></span>;</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(93, 108,
121);
background-color:
rgb(255, 255,
255);" class=""><span style="" class=""> </span>//
complete:</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> <span style="color:
#9b2393" class=""><b class="">switch</b></span>
(pid) {</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
<span style="color:
#9b2393" class=""><b class="">case</b></span>
<span style="color:
#1c00cf" class="">0xe003</span>:
{</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
<span style="color:
#9b2393" class=""><b class="">unsigned</b></span>
<span style="color:
#9b2393" class=""><b class="">int</b></span>
soh_raw = ((<span style="color:
#9b2393" class=""><b class="">unsigned</b></span>
<span style="color:
#9b2393" class=""><b class="">int</b></span>)rxbuf[<span style="color:
#1c00cf" class="">0</span>]
<< <span style="color:
#1c00cf" class="">8</span>)
| (<span style="color:
#9b2393" class=""><b class="">unsigned</b></span>
<span style="color:
#9b2393" class=""><b class="">int</b></span>)rxbuf[<span style="color:
#1c00cf" class="">1</span>];</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
<span style="color:
#9b2393" class=""><b class="">float</b></span>
soh = soh_raw
/ <span style="color:
#1c00cf" class="">10</span>;</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
StdMetrics.ms_v_bat_soh->SetValue(soh);</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
<span style="color:
#9b2393" class=""><b class="">break</b></span>;</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">
}</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class=""> }</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);" class="">}</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo; color:
rgb(93, 108,
121);
background-color:
rgb(255, 255,
255);" class="">//
end testing
polls</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div style="margin:
0px;
font-stretch:
normal;
line-height:
normal;
font-family:
Menlo;
background-color:
rgb(255, 255,
255);
min-height:
14px;" class=""><br class="">
</div>
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On
5 Mar 2021, at
12:37, Michael
Balzer <<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class="">
Shane,<br class="">
<br class="">
on OBD polling
basics: <a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/pipermail/ovmsdev/2020-December/014758.html" moz-do-not-send="true">http://lists.openvehicles.com/pipermail/ovmsdev/2020-December/014758.html</a><br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">Am
04.03.21 um
19:45 schrieb
Shane @ Kilve
Engineering:<br class="">
</div>
<blockquote type="cite" cite="mid:6580C00C-DF5C-4D81-80C6-B886FE5D21F9@kilve-engineering.co.uk" class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
Good evening
Michael,
<div class=""><br class="">
</div>
<div class="">Or
any one that
has the time
to help, </div>
<div class=""><br class="">
</div>
<div class="">Ive
now
successfully
retrieved as
much info as I
can without
polling any
info for the
maxus, but I
have have now
found an ecu
that responds
to pid
requests. </div>
<div class=""><br class="">
</div>
<div class="">For
example if I
use the obdii
pid scanner I
get the loads
of data back
and I’ve
decoded some
of it, just
need a bit of
guidance how
to write the
code to get
the same info </div>
<div class=""><br class="">
</div>
<div class="">A
part of a scan
is as follows</div>
<div class=""><br class="">
</div>
<div class="">
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Scan
complete (7e3
e000-e100)</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Scan
started :
2021-03-04
18:32:36 GMT</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Last
response:
2021-03-04
18:32:39 GMT</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e000
00</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e001
64</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e002
4b</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e003
26 bc</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e004
00 07</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e005
2f</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e006
2e</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e007
02 00</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e008
01 ff</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e009
02 00</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">7e3[7eb]:e010
02 00</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class=""><br class="">
</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">I
know that e003
is SOH = 26bc
= 9916 /100 =
99.16% SOH</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">And
e002 is a temp
4b = 75 / 10 =
7.5 degrees</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class=""><br class="">
</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">So
if some one
can help me
with an
example of how
to correctly
code this one
I can work out
the rest, </span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class=""><br class="">
</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Ive
looked through
various
vehicles but
everyone uses
different
methods and I
can’t seem to
get one to
work for me. </span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class=""><br class="">
</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Any
help much
appreciated </span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class=""><br class="">
</span></div>
<div style="margin:
0px;
font-stretch:
normal;
font-size:
13px;
line-height:
normal;
font-family:
Monaco; color:
rgb(2, 26, 0);
background-color: rgb(255, 255, 255);" class=""><span style="font-kerning:
none" class="">Shane</span></div>
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On
15 Feb 2021,
at 08:05,
Michael Balzer
<<a href="mailto:dexter@expeedo.de" class="" moz-do-not-send="true">dexter@expeedo.de</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Shane,<br class="">
<br class="">
I forgot to
mention: if
you're working
on a new
vehicle
module, you'll
also need to
start the bus
somewhere in
your
initialization
code. Example:<br class="">
<br class="">
RegisterCanBus(1,
CAN_MODE_ACTIVE, CAN_SPEED_500KBPS);<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
<br class="">
Am 15.02.21 um
08:36 schrieb
Michael
Balzer:<br class="">
<blockquote type="cite" class="">Shane,<br class="">
<br class="">
Am 14.02.21 um
16:42 schrieb
Shane @ Kilve
Engineering:<br class="">
<blockquote type="cite" class="">can
any one help
me with a bit
of code to
retrieve ve
some data from
ecu can1/6f2
00 4c 00 00 01
97 bc 00 as i
cant poll this
ecu it just
broadcasts
when its
active, ive
tried polling
it but does
not respond, i
need to choose
one byte and
allocate it to
a PID.<br class="">
</blockquote>
<br class="">
I don't know
what you mean
by "allocating
a byte to a
PID", but if
you want to
process frames
received
directly,
simply
override
IncomingFrameCan1()
(or …2/3/4
depending on
your bus).<br class="">
<br class="">
Reduced
example:<br class="">
<br class="">
void
OvmsVehicleXYZ::IncomingFrameCan1(CAN_frame_t
*p_frame)<br class="">
{<br class="">
uint8_t *d =
p_frame->data.u8;<br class="">
<br class="">
switch
(p_frame->MsgID)<br class="">
{<br class="">
case
0x6f2:<br class="">
// for
example,
assuming the
SOC is in byte
1:<br class="">
StdMetrics.ms_v_bat_soc->SetValue(d[1]);<br class="">
break;<br class="">
}<br class="">
}<br class="">
<br class="">
If you're
outside a
vehicle
context, you
can register
your own CAN
receiver by
creating a
queue and
calling
MyCan.RegisterListener().
See the
vehicle module
for an
example.<br class="">
<br class="">
Regards,<br class="">
Michael<br class="">
<br class="">
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev
mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev
mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
_______________________________________________<br class="">
OvmsDev mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
<span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span>OvmsDev@lists.openvehicles.com</span><br><span>http://lists.openvehicles.com/mailman/listinfo/ovmsdev</span><br></div></blockquote></div></body></html>