<html><head></head><body><div class="ydp338fe715yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div>
<div dir="ltr" data-setdir="false">Hi Michael,</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Even if I used to be a developer, I am not familiar with branching and PR in Git. Can someone else take it from here ?</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Didier<br></div><div><br></div>
</div><div id="yahoo_quoted_7218219093" class="yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
Le lundi 29 mars 2021 02 h 58 min 33 s UTC−4, Michael Balzer <dexter@expeedo.de> a écrit :
</div>
<div><br></div>
<div><br></div>
<div><div id="yiv9484428636"><div>
Didier,<br clear="none">
<br clear="none">
nice find, are you going to submit a PR for this fix?<br clear="none">
<br clear="none">
Regards,<br clear="none">
Michael<br clear="none">
<br clear="none">
<br clear="none">
<div class="yiv9484428636moz-cite-prefix">Am 28.03.21 um 23:46 schrieb
<a rel="nofollow noopener noreferrer" shape="rect" class="yiv9484428636moz-txt-link-abbreviated" ymailto="mailto:didier@ernotte.com" target="_blank" href="mailto:didier@ernotte.com">didier@ernotte.com</a>:<br clear="none">
</div>
<blockquote type="cite">
</blockquote></div><div><div class="yiv9484428636ydp4bd035c6yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;">
<div dir="ltr">Ok, I think I found the
issue.</div>
<div dir="ltr">In <br clear="none">
</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">
<div>
<div style="color:rgb(212, 212, 212);background-color:rgb(30, 30, 30);font-family:Menlo, Monaco, Courier New, monospace;font-weight:normal;font-size:12px;line-height:18px;white-space:pre-wrap;"><div><span style="color:#569cd6;">void</span><span style="color:#d4d4d4;"> </span><span style="color:#4ec9b0;">OvmsReToolsPidScanner</span><span style="color:#d4d4d4;">::</span><span style="color:#dcdcaa;">IncomingPollFrame</span><span style="color:#d4d4d4;">(</span><span style="color:#569cd6;">const</span><span style="color:#d4d4d4;"> </span><span style="color:#4ec9b0;">CAN_frame_t</span><span style="color:#569cd6;">*</span><span style="color:#d4d4d4;"> </span><span style="color:#9cdcfe;">frame</span><span style="color:#d4d4d4;">)</span></div><div><span style="color:#d4d4d4;">
</span></div></div>
</div>
<div><br clear="none">
</div>
<div dir="ltr">frameLength should not be a
8 bits, it should rather be a 16 bits<br clear="none">
</div>
</div>
<div><br clear="none">
</div>
<div dir="ltr">
<div>
<div style="color:rgb(212, 212, 212);background-color:rgb(30, 30, 30);font-family:Menlo, Monaco, Courier New, monospace;font-weight:normal;font-size:12px;line-height:18px;white-space:pre-wrap;"><div><span style="color:#d4d4d4;"> </span><span style="color:#4ec9b0;">uint8_t</span><span style="color:#d4d4d4;"> </span><span style="color:#9cdcfe;">frameLength</span><span style="color:#d4d4d4;"> = </span><span style="color:#9cdcfe;">frame</span><span style="color:#d4d4d4;">-></span><span style="color:#9cdcfe;">data</span><span style="color:#d4d4d4;">.</span><span style="color:#9cdcfe;">u8</span><span style="color:#d4d4d4;">[</span><span style="color:#b5cea8;">0</span><span style="color:#d4d4d4;">] & </span><span style="color:#b5cea8;">0x0f</span><span style="color:#d4d4d4;">;</span></div><div><span style="color:#d4d4d4;">
</span></div></div>
</div>
<div><br clear="none">
</div>
<div dir="ltr">Didier<br clear="none">
</div>
</div>
</div>
<div class="yiv9484428636yahoo_quoted" id="yiv9484428636yahoo_quoted_7221530860">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div> Le dimanche 28 mars 2021 13 h 40 min 02 s UTC−4, Michael
Balzer <a rel="nofollow noopener noreferrer" shape="rect" class="yiv9484428636moz-txt-link-rfc2396E" ymailto="mailto:dexter@expeedo.de" target="_blank" href="mailto:dexter@expeedo.de"><dexter@expeedo.de></a> a écrit : </div>
<div><br clear="none">
</div>
<div><br clear="none">
</div>
<div>
<div id="yiv9484428636">
<div> Didier,<br clear="none">
<br clear="none">
the PID scanner normally works perfectly with multi
frame responses, but I haven't had a response that long
yet.<br clear="none">
<br clear="none">
For 1503 bytes, 215 consecutive frames need to be
transmitted. The PID scanner requests these to be sent
with 25 ms separation time, so they should need 5.375
seconds.<br clear="none">
<br clear="none">
Maybe some frame gets lost, or maybe the device doesn't
allow a separation time that high for a transmission
that huge.<br clear="none">
<br clear="none">
Your log quote wasn't from the re-pid component but from
obd2ecu, which has nothing to do with the RE tools. You
should raise the log level for re-pid to see more info.
Another tracing option is to use the CAN log monitor.<br clear="none">
<br clear="none">
Btw, you should never need 30 seconds timeout for a PID
poll, as the scanner checks against the last frame
reception.<br clear="none">
<br clear="none">
Regards,<br clear="none">
Michael<br clear="none">
<br clear="none">
<br clear="none">
<div class="yiv9484428636yqt4532115954" id="yiv9484428636yqtfd44278">
<div class="yiv9484428636moz-cite-prefix">Am 28.03.21
um 17:52 schrieb <a rel="nofollow noopener noreferrer" shape="rect" class="yiv9484428636moz-txt-link-abbreviated" ymailto="mailto:didier@ernotte.com" target="_blank" href="mailto:didier@ernotte.com">didier@ernotte.com</a>:<br clear="none">
</div>
</div>
<blockquote type="cite">
<div class="yiv9484428636yqt4532115954" id="yiv9484428636yqtfd82566">
<div dir="ltr">I am investigating some PID with very
long data. I am using the PID scanner for this.</div>
<div dir="ltr">When I turn on the log level debug ,
I can see this as the first repy<br clear="none">
</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr"><br clear="none">
</div>
</div>
<div dir="ltr">
<div class="yiv9484428636yqt4532115954" id="yiv9484428636yqtfd00513"><span> </span>
<pre class="yiv9484428636ydp3da9169areceiver yiv9484428636ydp3da9169aget-window-resize" id="yiv9484428636ydp3da9169aoutput" style="min-height:549px;">D (1456677) obd2ecu: Rcv 7ec: 8 (15 df 62 48 83 0 0 0)
<font face="Helvetica Neue, Helvetica, Arial, sans-serif">From the Canbus doc, I understand that the first "1x (15)" tells me that this is the first frame of a multi frame, and the length is "5df" .
The Pid scanner seems to return only "df", not "5df" data, and I can see in the log that I have around 1500 byte returned, not 220.
Any explanation ? anyone see this problem as well ?
The scan command is (I had to hack the code to allow timeout > 10sec)
<span></span></font></pre>
<pre class="yiv9484428636ydpb4a697cereceiver yiv9484428636ydpb4a697ceget-window-resize" id="yiv9484428636ydpb4a697ceoutput" style="min-height:549px;">re obdii scan start 1 7e4 4883 4883 -r500-7ff -t22 -x30</pre>
</div>
</div>
</blockquote>
<br clear="none">
<pre class="yiv9484428636moz-signature">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
<div class="yiv9484428636yqt4532115954" id="yiv9484428636yqtfd54118"> </div>
</div>
</div>
<div class="yiv9484428636yqt4532115954" id="yiv9484428636yqtfd96454">_______________________________________________<br clear="none">
OvmsDev mailing list<br clear="none">
<a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:OvmsDev@lists.openvehicles.com" target="_blank" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br clear="none">
<a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br clear="none">
</div>
</div>
</div>
</div>
<br clear="none">
<fieldset class="yiv9484428636mimeAttachmentHeader"></fieldset>
<pre class="yiv9484428636moz-quote-pre">_______________________________________________
OvmsDev mailing list
<a rel="nofollow noopener noreferrer" shape="rect" class="yiv9484428636moz-txt-link-abbreviated" ymailto="mailto:OvmsDev@lists.openvehicles.com" target="_blank" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a rel="nofollow noopener noreferrer" shape="rect" class="yiv9484428636moz-txt-link-freetext" target="_blank" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
<div class="yiv9484428636yqt8226200831" id="yiv9484428636yqtfd87408"><br clear="none">
<pre class="yiv9484428636moz-signature">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div></div></div><div class="yqt8226200831" id="yqtfd56330">_______________________________________________<br clear="none">OvmsDev mailing list<br clear="none"><a shape="rect" ymailto="mailto:OvmsDev@lists.openvehicles.com" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br clear="none"><a shape="rect" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br clear="none"></div></div>
</div>
</div></body></html>