<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr">“Cellular” sounds good. I will make the change. “mod<tab>” has been aggravating me.</div><div dir="ltr"><br></div><div dir="ltr">P.S. Still working on it, but hopefully SIM5360 is working well.</div><div dir="ltr"><br><blockquote type="cite">On 30 Aug 2020, at 5:39 PM, Michael Balzer <dexter@expeedo.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Running smoothly on my bench module.<br>
<br>
Your refactorization changes also look good to me. (Side note: I'd
opt for generally keeping trailing white space. I use them for
graphical purposes and to denote continuing paragraphs in text files
(rst), which my editor automatically does to provide consistent
rewrapping.)<br>
<br>
I suggest renaming the command root "modem" to something not
breaking the "mo" or "mod" shortcut for "module". I generally try to
make/keep command abbreviations work at 2-3 characters.<br>
<br>
As "modem" is also a general device class (also applicable to the
wifi modem), how about calling it "cellular" instead?<br>
<br>
That would also allow to add some general cellular network specific
commands without breaking semantics.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 30.08.20 um 09:20 schrieb Mark
Webb-Johnson:<br>
</div>
<blockquote type="cite" cite="mid:CB14A00E-B52A-432C-B4D0-28B80B28E742@webb-johnson.net">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class=""><br class="">
</div>
The initial implementation of this work is in branch for-v3.3, in
GitHub. That branch can be used for the upcoming 3.3 release,
including potentially breaking changes.
<div class=""><br class="">
</div>
<div class="">I’d appreciate any feedback. For the SIM5360, the
behaviour should be unchanged from the current implementation
(except some improvements to edge cases and control logic). The
major user visible change is from ’simcom’ to ‘modem’ for the
console commands.</div>
<div class=""><br class="">
</div>
<div class="">Regards, Mark.<br class="">
<div class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 20 Aug 2020, at 9:35 PM, Mark
Webb-Johnson <<a href="mailto:mark@webb-johnson.net" class="" moz-do-not-send="true">mark@webb-johnson.net</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; line-break: after-white-space;" class="">
<div class=""><br class="">
</div>
<div class="">I have started the work on refactoring
the modem driver to support virtual driver
implementations (SIMCOM 5360 being just one of
them). This is a major refactoring that will take
some time to complete. It is likely that the
following components/files will be affected:</div>
<div class=""><br class="">
</div>
<div class="">
<ul class="MailOutline">
<li class="">Component simcom (major changes)</li>
<li class="">New component ovms_modem introduced</li>
<li class="">ovms_webserver/dev/commands.htm</li>
<li class="">ovms_webserver/src/web_cfg_init.cpp</li>
<li class="">ovms_webserver/src/web_cfg.cpp</li>
<li class="">Component powermgmt</li>
<li class="">And several other components
mentioning Simcom, but only very minor changes</li>
</ul>
</div>
<div class=""><br class="">
</div>
<div class="">I would appreciate it if no major
changes were made to those components in the next
week or two, as that may make merging difficult.</div>
<div class=""><br class="">
</div>
<div class="">Once I’ve got the modem code refactored,
and a compatible SIMCOM 5360 driver working, I’ll
publish to the for-v3.3 branch for wider testing. I
can then add the other modem drivers I have been
working on.</div>
<div class=""><br class="">
</div>
<div class="">Regards, Mark.</div>
<div class=""><br class="">
</div>
<div class="">P.S. Pretty obvious that this work is to
abstract out the modem type specific code, to make
it easier to add support for other modem types in
OVMS. This is a long-term project, and not something
happening anytime soon, but I am working on it.</div>
<div class=""><br class="">
</div>
</div>
_______________________________________________<br class="">
OvmsDev mailing list<br class="">
<a href="mailto:OvmsDev@lists.openvehicles.com" class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
<span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span>OvmsDev@lists.openvehicles.com</span><br><span>http://lists.openvehicles.com/mailman/listinfo/ovmsdev</span><br></div></blockquote></body></html>