<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body><div>I agree on not further discussing this. I made my point.</div><div><br></div><div>Chris</div><div><br></div><div>Am Freitag, den 14.08.2020, 10:02 +0200 schrieb Soko:</div><blockquote type="cite">
<p>I'm not quite sure if we should discuss this here or in the pull
request itself. Maybe Mark or Michael should say whats best.
Anyhow... Let me put you to ease with my <i>answers below...</i><br>
</p>
<div class="moz-cite-prefix">On 14.08.2020 09:18, Chris van der
Meijden wrote:<br>
</div>
<blockquote type="cite" cite="mid:1597389518.7830.1.camel@arachnon.de">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>Hey Soko,</div>
<div><br>
</div>
<div>sorry I don't agree on this pull request.</div>
</blockquote>
<i>Just to make things clear with the other guys: You are talking
about one of the pull requests, the one with the source split.</i><br>
<blockquote type="cite" cite="mid:1597389518.7830.1.camel@arachnon.de">
<div><br>
</div>
<div>We have already discussed this. </div>
<div><br>
</div>
<div>Lets put this straight. My code for the T26A part is not
ready yet. Climate control is still very buggy and it would
confuse the user to have such a buggy feature within a possible
OVMS release. It will take me probably a week or two, maybe
longer, to get the climate control fixed. Then we can do a pull
request to the master.</div>
</blockquote>
<p><i>The T26A code in my pull request is not the one from your
fork. It's the one that is officially in the master branch of
openvehicles. So nothing changes for the user and not one source
line is different then before.</i><br>
</p>
<blockquote type="cite" cite="mid:1597389518.7830.1.camel@arachnon.de">
<div><br>
</div>
<div>An other point we also talked about, is that you have not
documented your OBD part at all. This is also not acceptable.
You can't put features with in the official OVMS repository that
are not documented at all. How does the user use your VW e-Up
OBD part? What hardware is needed? Where does the user see the
results in the webfrontend? Does the app work with your code?
...</div>
</blockquote>
<p><i>The user is not able to use any of the OBD code as pointed out
in the pull request description. This is more an esthetic
question as the code is not active. If the others feel the same
I can remove my obd_*.* files from the pull request. The outcome
is the same... </i><br>
</p>
<blockquote type="cite" cite="mid:1597389518.7830.1.camel@arachnon.de">
<div><br>
</div>
<div>You can't put unready code in the master.</div>
<div><br>
</div>
<div>That is the reason why we use forks. We merge a fork when we
have kind of stable code with features that are well documented.
</div>
<div><br>
</div>
<div>This is not the case at the moment with the splitted VW e-Up
code.</div>
</blockquote>
<p><i>To sum up: Nothing at all changes for the user with me my pull
request. Well... besides the name of the VW e-Up vehicle. But is
taken care of in the upgrade method.</i></p>
<p><i>I even prepared everything so you have it as easy as possible
when this pull request is put into the master: When you pull it
your fork you only have to backup your three t26_*.* files from
your fork. Then just take 1:1 the openvehicles-master and put
your backup back.<br>
At least that's how I would do it as I'm not familiar how this
is done in git directly ;)</i><br>
</p>
<blockquote type="cite" cite="mid:1597389518.7830.1.camel@arachnon.de">
<div><br>
</div>
<div>Regards</div>
<div><br>
</div>
<div>Chris</div>
<div><br>
</div>
<div><br>
</div>
<div>Am Freitag, den 14.08.2020, 07:06 +0200 schrieb Soko:</div>
<blockquote type="cite">
<pre>Hey guys,
Just want to let you know on this way as well about the two pull
requests I have opened yesterday.
Let me know your thoughts. Would be cool if they will be merged very
soon so I can continue my work on the VW e-Up.
regards,
Soko
_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre></blockquote></body></html>