<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Mark,</div><div><br></div><div>I merged the new code, compiled and it works like charm. No more TPMS boxes for the VW e-Up within the app :-)</div><div><br></div><div>Thank you very much.</div><div><br></div><div>Greetinx</div><div><br></div><div>Chris</div><div><br></div><div><br></div><div>Am Freitag, den 06.03.2020, 14:47 +0100 schrieb Chris van der Meijden:</div><blockquote type="cite"><div>Hi Mark,</div><div><br></div><div>thank you for your quick response.</div><div><br></div><div>I created an issue on github. I feel still a bit to unexperienced to start coding on the core elements of OVMS. </div><div><br></div><div>Thank you for your help.</div><div><br></div><div>Regards</div><div><br></div><div>Chris</div><div><br></div><div><br></div><div>Am Freitag, den 06.03.2020, 20:03 +0800 schrieb Mark Webb-Johnson:</div><blockquote type="cite"><div dir="ltr">Looks like an oversight. The spec says:</div><div dir="ltr"><br></div><div dir="ltr"><div></div><blockquote type="cite"><div><span style="caret-color: rgb(64, 64, 64); color: rgb(64, 64, 64); font-family: "Roboto Slab", ff-tisa-web-pro, Georgia, Arial, sans-serif; font-size: 24px; -webkit-text-size-adjust: 100%;">Car TPMS message 0x57 “W”</span></div><h2 style="box-sizing: border-box; margin-top: 0px; font-family: "Roboto Slab", ff-tisa-web-pro, Georgia, Arial, sans-serif; font-size: 24px; caret-color: rgb(64, 64, 64); color: rgb(64, 64, 64); -webkit-text-size-adjust: 100%;"><a class="headerlink" href="https://docs.openvehicles.com/en/latest/protocol_v2/messages.html#car-tpms-message-0x57-w" title="Permalink to this headline" style="box-sizing: border-box; color: rgb(155, 89, 182); text-decoration: none; cursor: pointer; display: inline-block; font-weight: normal; font-stretch: normal; line-height: 1; font-family: inherit; font-size: 14px; text-rendering: auto; -webkit-font-smoothing: antialiased; visibility: hidden;"></a></h2><p style="font-size: 16px; box-sizing: border-box; line-height: 24px; margin: 0px 0px 24px; caret-color: rgb(64, 64, 64); color: rgb(64, 64, 64); font-family: Lato, proxima-nova, "Helvetica Neue", Arial, sans-serif; -webkit-text-size-adjust: 100%;">This message is sent <cartoserver> “C”, or <servertoapp> “s”, and transmits the last known TPMS values of the vehicle.</p><p style="font-size: 16px; box-sizing: border-box; line-height: 24px; margin: 0px 0px 24px; caret-color: rgb(64, 64, 64); color: rgb(64, 64, 64); font-family: Lato, proxima-nova, "Helvetica Neue", Arial, sans-serif; -webkit-text-size-adjust: 100%;"><data> is comma-separated list of:</p><ul class="simple" style="font-size: 16px; box-sizing: border-box; margin: 0px 0px 24px; padding: 0px; list-style-position: initial; list-style-image: initial; line-height: 24px; caret-color: rgb(64, 64, 64); color: rgb(64, 64, 64); font-family: Lato, proxima-nova, "Helvetica Neue", Arial, sans-serif; -webkit-text-size-adjust: 100%;"><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">front-right wheel pressure (psi)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">front-right wheel temperature (celcius)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">rear-right wheel pressure (psi)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">rear-right wheel temperature (celcius)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">front-left wheel pressure (psi)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">front-left wheel temperature (celcius)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">rear-left wheel pressure (psi)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">rear-left wheel temperature (celcius)</li><li style="box-sizing: border-box; list-style: disc; margin-left: 24px;">Stale TPMS indicator (-1=none, 0=stale, >0 ok)</li></ul></blockquote></div><div dir="ltr">We can test the metrics to see if they are defined. If not, then set stale to -1. Should just be another line in the server v2 code.</div><div dir="ltr"><br></div><div dir="ltr">Can you create a github issue, and I will fix. Or make the fix yourself and pull request?</div><div dir="ltr"><br></div><div dir="ltr">Regards, Mark</div><div dir="ltr"><br><blockquote type="cite">On 6 Mar 2020, at 6:31 PM, Chris van der Meijden <chris@arachnon.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span>Hi all,</span><br><span></span><br><span>as I can't find the CAN-ID's for TPMS for the VW e-Up at the moment, I</span><br><span>thought I just disable the feature, so the app won't display the TPMS</span><br><span>boxes unnecessarily.</span><br><span></span><br><span>In OVMS v2 this was possible by setting car_stale_tpms = -1 so the last</span><br><span>number sent by the "W" message to the server was -1. With that -1 the</span><br><span>app will not display the TMPS boxes.</span><br><span></span><br><span>The code in ovms_server_v2.cpp for the message is now</span><br><span></span><br><span> extram::ostringstream buffer;</span><br><span> buffer</span><br><span> << "MP-0 W"</span><br><span> << StandardMetrics.ms_v_tpms_fr_p->AsString("0",PSI)</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_fr_t->AsString("0")</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_rr_p->AsString("0",PSI)</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_rr_t->AsString("0")</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_fl_p->AsString("0",PSI)</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_fl_t->AsString("0")</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_rl_p->AsString("0",PSI)</span><br><span> << ","</span><br><span> << StandardMetrics.ms_v_tpms_rl_t->AsString("0")</span><br><span> << ((stale)?",0":",1")</span><br><span> ;</span><br><span></span><br><span> Transmit(buffer.str().c_str());</span><br><span></span><br><span>and that gives no room for sending a -1 as far as I understand it.</span><br><span></span><br><span>Is this a bug, a feature, or am I missing something?</span><br><span></span><br><span>Thanx for help</span><br><span></span><br><span>Greetinx</span><br><span></span><br><span>Chris</span><br><span></span><br><span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span>OvmsDev@lists.openvehicles.com</span><br><span>http://lists.openvehicles.com/mailman/listinfo/ovmsdev</span><br></div></blockquote><pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre></blockquote><pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre></blockquote></body></html>