<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body><div>Hi Michael,</div><div><br></div><div>thanx a lot for your nice and helpfull comments. I made some corrections.</div><div><br></div><div>Please feel free to take an other look at the code on future occasions. I really appreciate the remarks :-)</div><div><br></div><div>Greetinx</div><div><br></div><div>Chris</div><div><br></div><div><br></div><div>Am Samstag, den 29.02.2020, 17:05 +0100 schrieb Michael Balzer:</div><blockquote type="cite">
Chris,<br>
<br>
some first comments:<br>
<ul>
<li>Please don't use TAB indentation, only spaces, or add a
".editorconfig". Tabs have different width depending on the
editor & environment. Default indentation step for most of
the code is two (2) spaces, except for some submodules (which
have .editorconfig files as necessary, for example the zip
module). See <a href="https://editorconfig.org/">https://editorconfig.org/</a></li>
<li>ms_v_bat_12v_voltage is by default provided by the
housekeeping from the OVMS ADC (supply voltage), there is
currently no defined way to override this (maybe we should
introduce one?). If you set the metric, you will let the CAN
data fight against the ADC measurement (see housekeeping.cpp).
The advantage of the ADC measurement is it works all the time,
not only while the CAN bus is online.<br>
</li>
<li>Checking ms_v_env_awake staleness to detect the switch-off
will have a delay of 120 seconds, but I assume that's just a
temporary solution. I bet there is some way to read the state
from CAN.<br>
</li>
</ul>
Overall, nice & clean & good remarks.<br>
<br>
Btw, a typical CAN value scaling would be 100/256.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 26.02.20 um 09:07 schrieb Chris van
der Meijden:<br>
</div>
<blockquote type="cite" cite="mid:1582704426.2227.1.camel@arachnon.de">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div>I do have some "first code" now.</div>
<div><br>
</div>
<div>We found some CAN-ID's for the e-Up, so we could start the
work on some real functionality.</div>
<div><br>
</div>
<div>At this stage we have:</div>
<div><br>
</div>
<div>- SoC (hopefully)</div>
<div>- VIN</div>
<div>- Speed</div>
<div>- 12 volt battery current</div>
<div><br>
</div>
<div>This should be enough to bring first action within the app,
i.e. battery bar and parking notice.</div>
<div><br>
</div>
<div>I would like to invite you to take a look at the code here:</div>
<div><br>
</div>
<div><a href="https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle/vehicle.cpp" moz-do-not-send="true">https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle/vehicle.cpp</a></div>
<div><br>
</div>
<div>and give me some feedback. I wrote the code "blind" and
everything is untested because I don't have an OVMS v3 yet (it
is on its way) and our e-Up has also not arrived yet (hoping for
week 18 ...). So any hint on how to do better is welcome.</div>
<div><br>
</div>
<div>Thanx in advance.</div>
<div><br>
</div>
<div>Regards</div>
<div><br>
</div>
<div>Chris</div>
<div><br>
</div>
<div><br>
</div>
<div>Am Mittwoch, den 05.02.2020, 12:47 +0100 schrieb Chris van
der Meijden:</div>
<blockquote type="cite">
<div>It will take it's time though ...</div>
<div><br>
</div>
<div>At the moment I'm waiting for our e-Up to be delivered.
Hopefully in April and that is where the real fun starts.</div>
<div><br>
</div>
<div>I forgot to mention my website with my experiences with
OVMS for the Leaf and load of other stuff around e-mobility:</div>
<div><br>
</div>
<div><a href="http://www.arachnon.de/wb/pages/en/nissan-leaf/ovms.php" moz-do-not-send="true">http://www.arachnon.de/wb/pages/en/nissan-leaf/ovms.php</a></div>
<div><br>
</div>
<div>Just to complete my introduction :-)</div>
<div><br>
</div>
<div>Chris</div>
<div><br>
</div>
<div><br>
</div>
<div>Am Mittwoch, den 05.02.2020, 12:20 +0100 schrieb Michael
Balzer:</div>
<blockquote type="cite">
<div class="moz-cite-prefix">A quick addition:<br>
<br>
Chris' work will be covering at least three new vehicles.
The same vehicle drive train & electronics is used on…<br>
<ul>
<li>VW e-Up<br>
</li>
<li>SEAT Mii electric <br>
</li>
<li>ŠKODA CITIGOe iV<br>
</li>
</ul>
…also called "the new trio". These are very attractive
vehicles with a good balancing of price and capabilities,
and very good efficiency.<br>
<br>
It's quite possible the code can also partially be used on
other VW vehicles (e-Golf, ID.3?), as VW tends to reuse
components & protocols.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
Am 05.02.20 um 10:44 schrieb Chris van der Meijden:<br>
</div>
<blockquote type="cite" cite="mid:1580895853.4613.2.camel@arachnon.de">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<div style="color: rgb(0, 0, 0);">Dear OVMS-devs,</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">my name is Chris van der
Meijden (devmarxx) and I just started a new project on
integrating the VW e-Up into OVMS.</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">I mailed with Michael and
he provided me with usefull procedure hints. I forked OVMS
V3 and the Android code into my github account <a href="https://github.com/devmarxx?tab=repositories" moz-do-not-send="true">https://github.com/devmarxx?tab=repositories</a> and
commited my changes to the code there. I also started a
pull request, but there is no hurry, because my vehicle
code is just a template at the moment (like the Fiat 500 e
code). The Android code is complete, but Michael is quite
right that it would confuse the users to suddenly see the
VW e-Up when there is still no functionality, so no hurry
there too.</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">My experience on OVMS so
far is, that have been playing with the code for about 4
years. It started all because at that time I could not use
the Android app on my Cyanogenmod phone due to the "google
services" popup. I checked out the source code, removed
the google check line and voila I could use the app with
my Twizy and with my server :-)</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">Later we bought a Nissan
Leaf and I came in contact with Tom Parker. I had already
set up the OVMS V2 toolchain, so it was very nice that I
could use Tom's code to get the climate control of the
Leaf to work. Always nice mail contact with Tom. Amazing
the we can work together in New Zealand and Germany
without ever have met. That where good times :-)</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">So now we bought a VW
e-Up, that will be delivered hopefully in April. So I
thought now is a good time to get started with OVMS for
the VW e-Up. I decided to connect to the vehicle not over
the OBD connector, but through the OCU plug of the VW
e-Up. By doing so I hope to bypass the complicated VW CAN
TP2.0 protocoll and I will have direct access to the the
VW comfort CAN. Time will tell if that is the right
decission.</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">I started a thread at the
german goingelectric forum. Here I'll post my "adventures"
(in German) and I hope to find some co-coders there too <a href="https://www.goingelectric.de/forum/viewtopic.php?f=50&t=54620" moz-do-not-send="true">https://www.goingelectric.de/forum/viewtopic.php?f=50&t=54620</a></div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">Well .. So far my little
introduction. </div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">Looking forward to do some
happy coding together.</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">Greetinx</div>
<div style="color: rgb(0, 0, 0);"><br>
</div>
<div style="color: rgb(0, 0, 0);">Chris</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<br>
<pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre></blockquote></body></html>