<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    Mark,<br>
    <br>
    I did 1b73a7f8 to split the "create & compare password" function
    into separate "create" & "compare" steps, and introduced the
    "pw_encode" config hook to be able to supply just a custom "create"
    operation. That simplifies the config (see example).<br>
    <br>
    That change has been working since 2016 on my server. I see you
    reintroduced the "create & compare" function as a separate
    function for the MQTT auth, but don't see why that was needed. I
    also don't see why the separated function was broken on your server.
    Can you please elaborate? I'd like to understand what was going
    wrong.<br>
    <br>
    With reverting to the "create & compare", this breaks the
    configuration of servers not using Drupal. Essentially, the new
    "pw_check" hook does just the previous "pw_encode" and adds the
    comparison to that, so I'd rather opt for adding a default function
    here that simply reuses the existing "pw_encode" hook.<br>
    <br>
    Regards,<br>
    Michael<br>
    <br>
    <br>
    <div class="moz-cite-prefix">Am 20.02.20 um 04:09 schrieb Mark
      Webb-Johnson:<br>
    </div>
    <blockquote type="cite"
      cite="mid:F48FF6EE-9CB9-4DB5-8106-BE4CD73C5AE3@webb-johnson.net">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      Even stranger. This conversation obviously triggered someone to
      try it and then raise a support ticket that HTTP API
      authentication didn’t work.
      <div class=""><br class="">
      </div>
      <div class="">It seems  a change was made back in 2016-02-01
        23:59:22 (1b73a7f8) that broke the pw_encode function
        (drupal_password). It was also weird because we had
        drupal_password and drupal_password_check functions, doing
        pretty much the same thing (one used by HTTP API and the other
        by MQ authentication).</div>
      <div class=""><br class="">
      </div>
      <div class="">I standardised to use a new pw_check (overridable in
        the config) parameter, which defaults to:</div>
      <div class=""><br class="">
      </div>
      <blockquote style="margin: 0 0 0 40px; border: none; padding:
        0px;" class="">
        <div class=""><font class="" face="Andale Mono"><span
              style="font-style: normal; font-size: 14px;" class="">drupal_password_check($passwordhash,$password)</span></font></div>
      </blockquote>
      <div class="">
        <div><br class="">
        </div>
        <div>and stopped using the pw_encode config value. I also
          changed the MQ authentication stuff to use the same pw_check
          parameter (so both authentication uses are now able to be
          changed in the same config). If using something other than
          drupal, just need to change the pw_check parameter in the
          config.</div>
        <div><br class="">
        </div>
        <div>I realise that this may break other users of the server,
          but it doesn’t seem a difficult fix to make, and is a much
          better approach.</div>
        <div><br class="">
        </div>
        <div>Regards, Mark</div>
        <div><br class="">
          <blockquote type="cite" class="">
            <div class="">On 19 Feb 2020, at 1:53 PM, Mark Webb-Johnson
              <<a href="mailto:mark@webb-johnson.net" class=""
                moz-do-not-send="true">mark@webb-johnson.net</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <div class="">Strange. I have zero using mine. Must be a
                EU thing?<br class="">
                <br class="">
                I’ll keep it in mind and try not to break anything.<br
                  class="">
                <br class="">
                Regards, Mark.<br class="">
                <br class="">
                <blockquote type="cite" class="">On 18 Feb 2020, at 8:41
                  PM, Michael Balzer <<a
                    href="mailto:dexter@expeedo.de" class=""
                    moz-do-not-send="true">dexter@expeedo.de</a>>
                  wrote:<br class="">
                  <br class="">
                  Mark,<br class="">
                  <br class="">
                  grep "main: http" in the log: yes, I've got some users
                  accessing the API frequently.<br class="">
                  <br class="">
                  Usage is mostly /api/charge followed by /api/status
                  & /api/historical, but almost all calls have been
                  used during the last days.<br class="">
                  <br class="">
                  Regards,<br class="">
                  Michael<br class="">
                  <br class="">
                  <br class="">
                  Am 18.02.20 um 04:28 schrieb Mark Webb-Johnson:<br
                    class="">
                  <blockquote type="cite" class="">Is anyone here using
                    the HTTP API at all?<br class="">
                    <br class="">
                    It seems so tied to the v2 protocol, as to not be
                    much use.<br class="">
                    <br class="">
                    Regards, Mark.<br class="">
                    _______________________________________________<br
                      class="">
                    OvmsDev mailing list<br class="">
                    <a href="mailto:OvmsDev@lists.openvehicles.com"
                      class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br
                      class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class="">
                  </blockquote>
                  <br class="">
                  <br class="">
                  -- <br class="">
                  Michael Balzer * Helkenberger Weg 9 * D-58256
                  Ennepetal<br class="">
                  Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br
                    class="">
                  <br class="">
                  <br class="">
                  _______________________________________________<br
                    class="">
                  OvmsDev mailing list<br class="">
                  <a href="mailto:OvmsDev@lists.openvehicles.com"
                    class="" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br
                    class="">
                  <a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br
                    class="">
                </blockquote>
                <br class="">
                _______________________________________________<br
                  class="">
                OvmsDev mailing list<br class="">
                <a href="mailto:OvmsDev@lists.openvehicles.com" class=""
                  moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a><br
                  class="">
                <a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br
                  class="">
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
    </blockquote>
    <br>
    <pre class="moz-signature" cols="160">-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
  </body>
</html>