<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Ack. The response was an apology, but I'll rather spend my time on
our own issues first.<br>
<br>
I asked them about separate PRs with the initial commit. The PR
mostly contains Steve's and my changes, I think they are all well
done & documented and could also be merged by cherry picking if
necessary.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 13.02.20 um 00:53 schrieb Mark
Webb-Johnson:<br>
</div>
<blockquote type="cite"
cite="mid:B121EC18-A873-4F10-B271-1C377342540C@webb-johnson.net">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
It is ridiculous. I replied as follows:
<div class=""><br class="">
</div>
<blockquote style="margin: 0 0 0 40px; border: none; padding:
0px;" class="">
<div class="">
<blockquote type="cite" class="">This PR contains several
unrelated pieces - please split, one PR per single
functionality piece. The PR should be against the dev
branch, and one PR must have only one commit.<br class="">
</blockquote>
<br class="">
Is there any point? There are 33 pull requests here, dating
back to 5 years to 2015. Only three have any response, and
this one has sat dead since October 2018. It seems Cesanta is
simply not interested in community improvements? We could go
to the work to re-factor all these improvements and bug fixes
into individual PRs, but there seems little point unless they
get some attention.</div>
</blockquote>
<div class="">
<div><br class="">
</div>
<div>The way we are making our changes, to mongoose.h and
mongoose.c directly, isn’t really compatible with how they do
things anyway. We should probably be using their
tools/(un)amalgam.py scripts.</div>
<div><br class="">
</div>
<div>Let’s see what they reply (to my somewhat rude comment),
and go from there. There are so few changes been made to
cesanta/mongoose that it may just be easier for us to pull
from them.</div>
<div><br class="">
</div>
<div>Regards, Mark.</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 13 Feb 2020, at 4:49 AM, Stephen Casner
<<a href="mailto:casner@acm.org" class=""
moz-do-not-send="true">casner@acm.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">What happened? Did Mark's commit
58942ce96c5e3e14edb53c804ffcdd4127e226e7<br class="">
finally wake up cesanta? Are we going to resubmit all
of our changes<br class="">
as separate pull requests? One person does that, or
each author? And<br class="">
to the extent that they may be interdependent, so we
need for them to<br class="">
be accepted in order?<br class="">
<br class="">
-- Steve<br
class="">
<br class="">
---------- Forwarded message ----------<br class="">
Date: Wed, 12 Feb 2020 01:35:43 -0800<br class="">
From: Sergey Lyubka <<a
href="mailto:notifications@github.com" class=""
moz-do-not-send="true">notifications@github.com</a>><br
class="">
Reply-To: cesanta/mongoose<br class="">
<<a
href="mailto:reply+ABG5G6FIED7L3BL25LSLI4F4KD4W7EVBNHHBDAFYO4@reply.github.com"
class="" moz-do-not-send="true">reply+ABG5G6FIED7L3BL25LSLI4F4KD4W7EVBNHHBDAFYO4@reply.github.com</a>><br
class="">
To: cesanta/mongoose <<a
href="mailto:mongoose@noreply.github.com" class=""
moz-do-not-send="true">mongoose@noreply.github.com</a>><br
class="">
Cc: Stephen Casner <<a href="mailto:casner@acm.org"
class="" moz-do-not-send="true">casner@acm.org</a>>,
Mention <<a href="mailto:mention@noreply.github.com"
class="" moz-do-not-send="true">mention@noreply.github.com</a>><br
class="">
Subject: Re: [cesanta/mongoose] LWIP SO_REUSEADDR &
ESP32 logging (#894)<br class="">
<br class="">
This PR contains several unrelated pieces - please
split, one PR per single functionality piece. The PR
should be against the `dev` branch, and one PR must have
only one commit.<br class="">
<br class="">
-- <br class="">
You are receiving this because you were mentioned.<br
class="">
Reply to this email directly or view it on GitHub:<br
class="">
<a
href="https://github.com/cesanta/mongoose/pull/894#issuecomment-585116086"
class="" moz-do-not-send="true">https://github.com/cesanta/mongoose/pull/894#issuecomment-585116086</a><br
class="">
_______________________________________________<br
class="">
OvmsDev mailing list<br class="">
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br
class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="160">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
</body>
</html>