<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>I have enhanced Nissan LEAF HVAC metrics as well as added additional ones under xnl.cc</div><div><br></div><div>I have built and tested the changes and so far all works as intended.</div><div><br></div><div>I have also updated documentation.</div><div><br></div><div>So I think it is time to merge this in to current edge build, but I just wanted to check with you if all the code style and naming conventios are according to standards.</div><div><br></div><div>Would appreciate if someone could review and advise if something needs to be corrected.</div><div><br></div><div>Here is the link to the repo and main file I worked on: <a href="https://github.com/mjkapkan/Open-Vehicle-Monitoring-System-3/commits/master/vehicle/OVMS.V3/components/vehicle_nissanleaf/src/vehicle_nissanleaf.cpp">https://github.com/mjkapkan/Open-Vehicle-Monitoring-System-3/commits/master/vehicle/OVMS.V3/components/vehicle_nissanleaf/src/vehicle_nissanleaf.cpp</a></div><div><br>Kindly,<br><div dir="ltr"><p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><br></p><p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><b><span lang="EN-US" style="background-color: rgba(255, 255, 255, 0);">Jaunius Kapkan </span></b><i style="background-color: rgba(255, 255, 255, 0);">[Sent from cellphone]</i></p><p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-US" style="background-color: rgba(255, 255, 255, 0);">Global Market Operations</span></p><p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><span style="background-color: rgba(255, 255, 255, 0);"><span lang="EN-US">Cell: </span><span lang="EN-US"> </span><span lang="EN-US"> <a href="tel:+370%C2%A0650%2011%C2%A0752" dir="ltr" x-apple-data-detectors="true" x-apple-data-detectors-type="telephone" x-apple-data-detectors-result="26">+370 650 11 752</a></span></span></p></div><div dir="ltr"><br><blockquote type="cite">On 2019-10-17, at 15:14, Jaunius Kapkan <jaunius@gmx.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div style="font-family: Verdana;font-size: 12.0px;"><div>Thanks Mark,</div>
<div> </div>
<div>[renaming subject]</div>
<div> </div>
<div>In regards to config store. Where would you recommend placing the timers? I was thinking about putting them under vehicle conf:</div>
<div>
<pre id="output"><strong>OVMS#</strong> <kbd>config list vehicle</kbd>
vehicle (readable writeable)
bms.alerts.enabled: yes
bms.dev.temp.alert:
bms.dev.temp.warn:
bms.dev.voltage.alert:
bms.dev.voltage.warn:
cctimer.evening: 1715-1730
cctimer.morning: 0800-0815
id: ******
minsoc: 20
name:
timezone: EET-2EEST,M3.5.0/3,M10.5.0/4
timezone_region: Europe/Helsinki
units.distance: K</pre>
</div>
<div>Any other suggestions?</div>
<div> </div>
<div>Regards,</div>
<div>Jaunius</div>
<div>
<div name="quote" style="margin:10px 5px 5px 10px; padding: 10px 0 10px 10px; border-left:2px solid #C3D9E5; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div style="margin:0 0 10px 0;"><b>Sent:</b> Monday, October 14, 2019 at 4:01 AM<br>
<b>From:</b> "Mark Webb-Johnson" <mark@webb-johnson.net><br>
<b>To:</b> "OVMS Developers" <ovmsdev@lists.openvehicles.com><br>
<b>Subject:</b> Re: [Ovmsdev] WifiConsole V1.0</div>
<div name="quoted-content">
<div>Probably not. The majority of power consumption is from the modems (cellular and wifi).
<div> </div>
<div>Regards, Mark</div>
<div> </div>
<div>P.S. If all you need is a 10 second notification, you can pubsub subscribe to the standard event ticker.10.</div>
<div>
<div>
<blockquote>
<div>On 14 Oct 2019, at 7:22 AM, Jaunius Kapkan <<a href="mailto:jaunius@gmx.com" target="_blank">jaunius@gmx.com</a>> wrote:</div>
<div>
<div>
<div style="font-family: Verdana;font-size: 12.0px;">
<div>
<div>Delayed events seem to be working fine, thanks for the examples!</div>
<div>However, do you think spamming the events API every 10 seconds might substantially increase power consumption?</div>
<div>
<div> </div>
<div>
<ul id="eventlog">
<li><code>[2:17:04 AM]</code>usr.CCtimer.heartbeat</li>
<li><code>[2:17:04 AM]</code>usr.CCtimer.Night.stopped</li>
<li><code>[2:17:14 AM]</code>usr.CCtimer.heartbeat</li>
</ul>
</div>
<div>Regards,</div>
<div>Jaunius</div>
<div style="margin: 10.0px 5.0px 5.0px 10.0px;padding: 10.0px 0 10.0px 10.0px;border-left: 2.0px solid rgb(195,217,229);">
<div style="margin: 0 0 10.0px 0;"><b>Sent:</b> Sunday, October 13, 2019 at 8:54 PM<br>
<b>From:</b> "Michael Balzer" <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>><br>
<b>To:</b> <a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
<b>Subject:</b> Re: [Ovmsdev] WifiConsole V1.0</div>
<div>Sending notifications is now also supported directly:<br>
<br>
<a href="https://docs.openvehicles.com/en/latest/userguide/scripting.html#ovmsnotify" target="_blank">https://docs.openvehicles.com/en/latest/userguide/scripting.html#ovmsnotify</a><br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
Am 13.10.19 um 16:09 schrieb Jaunius Kapkan:<br>
> Great,<br>
><br>
> Will try that out!<br>
><br>
> Regards,<br>
> Jaunius<br>
><br>
>> Sent: Sunday, October 13, 2019 at 11:20 AM<br>
>> From: "Michael Balzer" <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>><br>
>> To: <a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
>> Subject: Re: [Ovmsdev] WifiConsole V1.0<br>
>><br>
>> Jaunius,<br>
>><br>
>> I've added scheduled (delayed) events & the native OvmsEvents API:<br>
>> <a href="https://docs.openvehicles.com/en/latest/userguide/scripting.html#internal-objects-and-functions-methods" target="_blank">https://docs.openvehicles.com/en/latest/userguide/scripting.html#internal-objects-and-functions-methods</a><br>
>><br>
>> So you can now also implement millisecond resolution timeouts and intervals in scripts.<br>
>><br>
>> Regards,<br>
>> Michael<br>
>><br>
>><br>
>> Am 11.10.19 um 10:36 schrieb Jaunius Kapkan:<br>
>>> Thanks Michael,<br>
>>> <br>
>>> 1 second will do just fine as this is for climate control timer plugin I'm doing. Will try to use that event listener. Of course some standartized way would<br>
>>> be better.<br>
>>> <br>
>>> Regards,<br>
>>> Jaunius<br>
>>> <br>
>>> *Sent:* Friday, October 11, 2019 at 8:48 AM<br>
>>> *From:* "Michael Balzer" <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>><br>
>>> *To:* <a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
>>> *Subject:* Re: [Ovmsdev] WifiConsole V1.0<br>
>>> Jaunius,<br>
>>><br>
>>> setTimeout() is not a standard Javascript function, it's a method of the browser window object.<br>
>>><br>
>>> <a href="https://developer.mozilla.org/de/docs/Web/API/WindowTimers/setTimeout" target="_blank">https://developer.mozilla.org/de/docs/Web/API/WindowTimers/setTimeout</a><br>
>>><br>
>>> As a workaround, subscribe to the "ticker.1" event as shown in the foglight example:<br>
>>><br>
>>> <a href="http://docs.openvehicles.com/en/latest/components/ovms_script/docs/foglight.html#listen-to-events" target="_blank">http://docs.openvehicles.com/en/latest/components/ovms_script/docs/foglight.html#listen-to-events</a><br>
>>><br>
>>> Resolution is limited to 1 second though. I thought about scheduled events some time ago, i.e. being able to tell the event system to trigger an event after a<br>
>>> specific delay. That would also offer a clean & simple solution for this. Another option would be a script API for the timer service.<br>
>>><br>
>>> I'll have a look at scheduled events.<br>
>>><br>
>>> Regards,<br>
>>> Michael<br>
>>><br>
>>> <br>
>>> Am 11.10.19 um 08:29 schrieb Jaunius Kapkan:<br>
>>><br>
>>> Thanks Mark,<br>
>>> <br>
>>> One other thing I stumbled upon is that standard setTimeout() does not seem to work. Is there any workaround for this? Sample Code:<br>
>>><br>
>>> |function intervalFunc() { print('Next try in 1.5s') } setInterval(intervalFunc, 1500)|<br>
>>><br>
>>> <br>
>>> Basically I need the script to check certain conditions each n seconds.<br>
>>> <br>
>>> Regards,<br>
>>> Jaunius<br>
>>> *Sent:* Thursday, October 10, 2019 at 3:35 AM<br>
>>> *From:* "Mark Webb-Johnson" <<a href="mailto:mark@webb-johnson.net" target="_blank">mark@webb-johnson.net</a>><br>
>>> *To:* "OVMS Developers" <<a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a>><br>
>>> *Subject:* Re: [Ovmsdev] WifiConsole V1.0<br>
>>> I think in v2 that could have been the case (as we didn’t have any standardised functions for things like climate control). But in the v3 architecture we<br>
>>> now have these and the vehicle modules should support the standard functions to the best of their abilities.<br>
>>><br>
>>> If we still need mappings like Homelink 1 -> Climate On, then that should be done either by scripts or by some centralised mapping framework.<br>
>>><br>
>>> Regards, Mark.<br>
>>><br>
>>> > On 9 Oct 2019, at 2:19 PM, Jaunius Kapkan <<a href="mailto:jaunius@gmx.com" target="_blank">jaunius@gmx.com</a>> wrote:<br>
>>> ><br>
>>> > I am making a couple of plugins (initially for leaf) and the JS functions are great for that. However I assume the functions are not unifed accross<br>
>>> different vehicles. For example for leaf to turn on pre-heat you need to issue Homelink 1 instead of ClimateControl. What would be the best way to change<br>
>>> this? Or is this something that need to be changed on the lower level?<br>
>>> ><br>
>>> > Greetings,<br>
>>> > Jaunius<br>
>>> ><br>
>>> >> Sent: Tuesday, October 08, 2019 at 9:05 AM<br>
>>> >> From: "Michael Balzer" <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>><br>
>>> >> To: <a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
>>> >> Subject: Re: [Ovmsdev] WifiConsole V1.0<br>
>>> >><br>
>>> >> Mark,<br>
>>> >><br>
>>> >> yes, the OLEDs are perfect for these things, bright enough for daylight use with very little energy usage.<br>
>>> >><br>
>>> >> Thanks for the link to that combined ESP32 module, that's a real beauty, even includes a LiPo supply / charger. I need to check that one out.<br>
>>> >><br>
>>> >> Regarding our Javascript support, I already had stunned some users with the foglight plugin, they thought stuff like this would need builtin<br>
>>> >> support. That brought me back to my point about how little users know about our capabilities, so I added an explanation to our docs:<br>
>>> >><br>
>>> >> <a href="http://docs.openvehicles.com/en/latest/components/ovms_script/docs/foglight.html" target="_blank">http://docs.openvehicles.com/en/latest/components/ovms_script/docs/foglight.html</a><br>
>>> >><br>
>>> >> But we really need something like an OVMS cheat sheet as an overview of what is possible.<br>
>>> >><br>
>>> >> Regards,<br>
>>> >> Michael<br>
>>> >><br>
>>> >><br>
>>> >> Am 08.10.19 um 05:40 schrieb Mark Webb-Johnson:<br>
>>> >>> Michael,<br>
>>> >>><br>
>>> >>> I really like those little OLED SSD1306 based displays. I use them on my esphome+hassio projects like this little water tank level (using an<br>
>>> >>> ESP32, a BME280 pressure/humidity/temperature sensor, waterproof ultrasonic distance sensor, and SSID1306 OLED yellow/blue display):<br>
>>> >>><br>
>>> >>><br>
>>> >>> Adding a display to a project makes it so much more useful and easy to diagnose problems.<br>
>>> >>><br>
>>> >>> AliExpress has them very cheap:<br>
>>> >>><br>
>>> >>> * <a href="https://www.aliexpress.com/item/32844104782.html" target="_blank">https://www.aliexpress.com/item/32844104782.html</a><br>
>>> >>> US$2 for the 0.96” yellow/blue 128x32<br>
>>> >>> US$3 for the 1.3” white 128x64<br>
>>> >>><br>
>>> >>><br>
>>> >>> There is also a 4MB ESP32 with a 0.96” OLED display on-board:<br>
>>> >>><br>
>>> >>> * <a href="https://www.aliexpress.com/item/32822105291.html" target="_blank">https://www.aliexpress.com/item/32822105291.html</a><br>
>>> >>> US$9 plus shipping<br>
>>> >>><br>
>>> >>><br>
>>> >>> Glad that you are finding a use for our JavaScript support. I really think that has so many possibilities.<br>
>>> >>><br>
>>> >>> Regards, Mark<br>
>>> >>><br>
>>> >>>> On 6 Oct 2019, at 10:43 PM, Michael Balzer <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a> <<a href="mailto:dexter@expeedo.de" target="_blank">mailto:dexter@expeedo.de</a>>> wrote:<br>
>>> >>>><br>
>>> >>>> FYI: I've just implemented an OVMS v3 style replacement for the SimpleConsole:<br>
>>> >>>><br>
>>> >>>> <a href="https://github.com/dexterbg/WifiConsole" target="_blank">https://github.com/dexterbg/WifiConsole</a><br>
>>> >>>><br>
>>> >>>> V3 makes it pretty easy now to add stuff like this. It's using a script plugin to provide custom functions via the web API.<br>
>>> >>>><br>
>>> >>>> Regards,<br>
>>> >>>> Michael<br>
>>> >><br>
>>> >> --<br>
>>> >> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
>>> >> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
>>> >><br>
>>> >> _______________________________________________<br>
>>> >> OvmsDev mailing list<br>
>>> >> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>>> >> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>>> >><br>
>>> > _______________________________________________<br>
>>> > OvmsDev mailing list<br>
>>> > <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>>> > <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>>><br>
>>> _______________________________________________<br>
>>> OvmsDev mailing list<br>
>>> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>>> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>>> <br>
>>> <br>
>>><br>
>>> _______________________________________________<br>
>>> OvmsDev mailing list<br>
>>> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>>> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>>><br>
>>> <br>
>>> --<br>
>>> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
>>> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
>>> _______________________________________________ OvmsDev mailing list <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>>><br>
>>> _______________________________________________<br>
>>> OvmsDev mailing list<br>
>>> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>>> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>> --<br>
>> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
>> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
>><br>
>> _______________________________________________<br>
>> OvmsDev mailing list<br>
>> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
>> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
>><br>
> _______________________________________________<br>
> OvmsDev mailing list<br>
> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
<br>
--<br>
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
<br>
_______________________________________________<br>
OvmsDev mailing list<br>
<a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></div>
</div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
OvmsDev mailing list<br>
<a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></div>
</blockquote>
</div>
</div>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></div>
</div>
</div>
</div></div>
<span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span>OvmsDev@lists.openvehicles.com</span><br><span>http://lists.openvehicles.com/mailman/listinfo/ovmsdev</span><br></div></blockquote></div></div></div></body></html>