<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Mark,<br>
<br>
see
<a class="moz-txt-link-freetext" href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/166">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/166</a><br>
<br>
…and followup commits bbb6885ef0f045867a4aaf18488157a6f9de56ea
& d28110930af98073d18368311e42a30e72a87387<br>
<br>
tl;dr: the user should be in control over this (and now is).<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
Am 15.08.19 um 02:46 schrieb Mark Webb-Johnson:<br>
</div>
<blockquote type="cite"
cite="mid:D37E8C6B-49E2-498B-9594-D0196B1C79A6@webb-johnson.net">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class=""><br class="">
</div>
<div class="">The original implementation was to use this in
vehicle modules that required GPS from the modem (and not from
car CAN bus signals):</div>
<div class=""><br class="">
</div>
<div class="">
<blockquote style="margin: 0px 0px 0px 40px; border: none;
padding: 0px;" class="">
<div class="">MyEvents.SignalEvent("vehicle.require.gps",
NULL);</div>
<div class="">MyEvents.SignalEvent("vehicle.require.gpstime",
NULL);</div>
</blockquote>
</div>
<div class=""><br class="">
</div>
<div class="">There was also the ‘modem’ ‘enable.gps’ and
‘enable.gpstime’ configuration.</div>
<div class=""><br class="">
</div>
<div class="">Reviewing the code now, I can’t see the
implementation of this any more. We now seem to work solely from
the ‘enable.gps’ and ‘enable.gpstime’ in the modem config.</div>
<div class=""><br class="">
</div>
<div class="">Any objections / suggestions to putting this back?
Perhaps with a RegisterGPS(bool) and RegisterGPSTime(bool) in
the vehicle base class, then have simcom GsmNMEA check the
config and current vehicle - with config overriding vehicle
preferences?</div>
<div class=""><br class="">
</div>
<div class="">Regards, Mark.</div>
</blockquote>
<br>
<pre class="moz-signature" cols="144">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
</body>
</html>