<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">All merged.<div class=""><br class=""></div><div class="">Only issue I had was that I was getting empty vehicleid in the topic id. Like this:</div><div class=""><br class=""></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;" class=""><div class=""><div class="">I (22478) ovms-server-v3: Tx metric ovms//m/freeram=4238232</div><div class="">I (22478) ovms-server-v3: Tx metric ovms//m/hardware=OVMS WIFI BLE BT cores=2 rev=ESP32/1</div><div class="">I (22478) ovms-server-v3: Tx metric ovms//m/monotonic=22</div><div class="">I (22478) ovms-server-v3: Tx metric ovms//m/net/mdm/iccid=</div></div></blockquote><div class=""><div><br class=""></div><div>I think the problem is that topic_prefix is set in the ConfigChanged, but m_vehicleid is set at Connect() stage.</div><div><br class=""></div><div>For simplicity, I moved m_topic_prefix initialisation to the Connect() function, like the others. But that means you need to stop/start the server if the topic prefix is changed in config. That is the same as username, password, etc, so should be acceptable.</div><div><br class=""></div><div>Seems nice and stable to me now. Thanks for the mongoose fix (moving stuff around by pre-pending headers was a horrible kludge by mongoose anyway).</div><div><br class=""></div><div>Regards, Mark.</div><div><br class=""><blockquote type="cite" class=""><div class="">On 4 Jul 2018, at 8:30 PM, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net" class="">mark@webb-johnson.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Yes, I'm trying to get this to a workable state.<br class=""><br class="">Your changes look good. I will try to merge within the next few hours.<br class=""><br class="">Regarding trusted ca cents, I don't think we need (or have space for) them all. Just the ones we use (and a way to add custom ones if necessary).<br class=""><br class="">Regards, Mark<br class=""><br class=""><blockquote type="cite" class="">On 4 Jul 2018, at 8:03 PM, Jakob Löw <<a href="mailto:ovms@m4gnus.de" class="">ovms@m4gnus.de</a>> wrote:<br class=""><br class="">Hey,<br class=""><br class="">I've seen some changes pushed to the repo regarding the v3 server. I<br class="">did some development on that too and found it to be very unstable,<br class="">often crashing after start (when transmitting all metrics) or when the<br class="">NetUp was called before any interface was up. Both issues were<br class="">connected to race conditions. I opened two pull requests to fix them<br class="">[0], [1].<br class="">The first one also introduces a new configuration option to set a<br class="">custom prefix for the MQTT topic. OVMS metric names seem to use a sort<br class="">of namespacing using dots, like m.freeram or v.e.on. Replacing dots in<br class="">metric names by slashes in MQTT topics, makes the OVMS follow MQTT<br class="">namespacing rules (m/freeram and v/e/on).<br class=""><br class="">One thing currently missing with the Server V3 is encryption. Mongoose<br class="">supports SSL so enabling it would be easy, but the problem is the<br class="">certificate management. We could allow users to load certs onto the<br class="">module, however this is something unexperienced users wouldnt do.<br class="">Another option is to ship the OVMS with a list of common root certs,<br class="">like many browsers do. The certs shipped with firefox are ~500KB and<br class="">can be easily obtained e.g. from the debian repos [2]. This could then<br class="">also be used by the server v2 to replace the outdated RC4 encryption.<br class=""><br class="">- Jakob<br class=""><br class="">[0] <a href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pu" class="">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pu</a><br class="">ll/137<br class="">[1] <a href="https://github.com/openvehicles/mongoose/pull/1" class="">https://github.com/openvehicles/mongoose/pull/1</a><br class="">[2] <a href="https://packages.debian.org/stretch/ca-certificates" class="">https://packages.debian.org/stretch/ca-certificates</a><br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev<br class=""></blockquote><br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev<br class=""></div></div></blockquote></div><br class=""></div></body></html>