<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">… or have it depend on “Include the GPL licensed WOLFSSH and WOLFSSL” and come up as an option under there when enabled.<div class=""><br class=""></div><div class="">Regards, Mark.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 27 Apr 2018, at 1:27 PM, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net" class="">mark@webb-johnson.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><blockquote type="cite" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 14px;" class="">It would be good to have a menu config option to define DEBUG_WOLFSSH.<br class=""></blockquote><br style="font-family: Menlo-Regular; font-size: 14px;" class=""><span style="font-family: Menlo-Regular; font-size: 14px;" class="">I think the only penalty for enabling it always is an increase in code</span><br style="font-family: Menlo-Regular; font-size: 14px;" class=""><span style="font-family: Menlo-Regular; font-size: 14px;" class="">size, ssuming the "_impure_ptr" is fixed in some way. I asked Mark if</span><br style="font-family: Menlo-Regular; font-size: 14px;" class=""><span style="font-family: Menlo-Regular; font-size: 14px;" class="">that would be reasonable to enable always.</span></blockquote><div class=""><br class=""></div><div class="">I guess it depends on how much bigger. Debugging the internals of wolfssh is seemingly a rare occurence? Perhaps a menuconfig option (in Components / OVMS / Developer Options) would make sense?</div><div class=""><br class=""></div><div class="">Regards, Mark.</div><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 27 Apr 2018, at 1:16 PM, Stephen Casner <<a href="mailto:casner@acm.org" class="">casner@acm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Thu, 26 Apr 2018, Robin O'Leary wrote:<br class=""><br class=""><blockquote type="cite" class="">On Fri, Apr 20, 2018 at 11:39:18PM -0700, Stephen Casner wrote:<br class=""><blockquote type="cite" class="">On Fri, 20 Apr 2018, Robin O'Leary wrote:<br class=""><blockquote type="cite" class="">OK, so that started me on quite an adventure in to compiler errors<br class="">and git submodules,<br class=""></blockquote>Sorry, did my commit of an update to mongoose trip you up?<br class=""></blockquote><br class="">That was just one of several things, but one of the easily resolved ones!<br class="">Much more annoying was a mysterious error about an undefined reference to<br class="">"_impure_ptr", since that appears nowhere in the code. I tracked it<br class="">down to the fprintf in wolfssh/src/log.c; I still don't understand why,<br class="">but I just commented it out, as ovms uses logFunction instead.<br class=""></blockquote><br class="">Oh, I do remember hitting that one myself and having to use Google for<br class="">help. I think I hit that when I tried to add a printf statement of my<br class="">own, so maybe if I saw it when enabling DEBUG_WOLFSSH I used the same<br class="">workaround that you did. I had not remembered that problem when<br class="">suggesting that you try DEBUG_WOLFSSH. Sorry.<br class=""><br class=""><blockquote type="cite" class=""><blockquote type="cite" class="">Perhaps I<br class="">should configure in the debug code for wolfssh and wolfssl by default<br class="">so the extra logging can be enabled whenever it is needed.<br class=""></blockquote><br class="">Adding more calls to GetErrorString() in ssh.c is probably more helpful.<br class=""></blockquote><br class="">That is done, but there is only one error code that is returned for<br class="">any cipher, MAC or key mismatch, so DEBUG_WOLFSSH is still required to<br class="">figure out which one.<br class=""><br class=""><blockquote type="cite" class="">It would be good to have a menu config option to define DEBUG_WOLFSSH.<br class=""></blockquote><br class="">I think the only penalty for enabling it always is an increase in code<br class="">size, ssuming the "_impure_ptr" is fixed in some way. I asked Mark if<br class="">that would be reasonable to enable always.<br class=""><br class=""><blockquote type="cite" class=""><blockquote type="cite" class="">WolfSSH also supports aes128-ctr and aes128-gcm, but I was warned that<br class="">the latter is much more expensive in speed and memory, so I excluded<br class="">it from the configuration for compilation.<br class=""></blockquote><br class="">I think there is full support for aes128-ctr in wolfssl/wolfcrypt, but<br class="">the places where it needs to be in wolfssh seem to be mostly missing.<br class="">I had a go at adding it, but I haven't got it working. It does connect,<br class="">but auth always fails. I haven't had chance to figure out why yet.<br class=""></blockquote><br class="">wolfssh/src/internal.c does reference AES128_CTR in a few places, but<br class="">I'm not sure what actions are required.<br class=""><br class="">I started with WolfSSH 1.1.0 when doing the integration into OVMS.<br class="">There is a 1.2.0 release out now (on github at wolfSSL/wolfssh), and a<br class="">1.3.0 release pending that will include Wolf's integration of my SCP<br class="">additions back into their code base.<br class=""><br class=""> -- Steve<br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class=""><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br class=""></div></div></blockquote></div><br class=""></div>_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev<br class=""></div></blockquote></div><br class=""></div></body></html>