<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Perfect. Done; pull request created.<br>
<br>
I considered leaving the 'obdii ecu list' command as not secure, as
normally it's just mph and such, but someone could mess with the PID
mapping and create an issue there. Also, the list can report what
PIDs are being requested by the OBDII device, which could be an
information leak.<br>
<br>
Greg<br>
<br>
<br>
<div class="moz-cite-prefix">Michael Balzer wrote:<br>
</div>
<blockquote type="cite"
cite="mid:3731b51c-067d-b10f-5b77-7a7900eabf51@expeedo.de">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Greg,<br>
<br>
you need to set the secure flag as required on your command
registration:<br>
<br>
<tt>OvmsCommand* OvmsCommand::RegisterCommand(const char* name,
const char* title, void (*execute)(int, OvmsWriter*,
OvmsCommand*, int, const char* const*),</tt><tt><br>
</tt><tt> const char
*usage, int min, int max, </tt><tt><b>bool secure</b></tt><tt>)</tt><br>
<br>
Everything else is handled by the system.<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 18.03.2018 um 17:47 schrieb Greg
D.:<br>
</div>
<blockquote type="cite"
cite="mid:2981094f-2d15-021b-7b20-79835e8c7d1d@gmail.com">
<pre wrap="">Colored banner is fine. Nice touch.
Do I need to do anything in the obdii code to fix the security issues,
or is that taken care of in the command parser?
Greg
Stephen Casner wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I'm fine with not setting a color on the prompts. Perhaps the color
should also be removed from the welcome banner?
-- Steve
</pre>
</blockquote>
<pre wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.teslaclub.hk" moz-do-not-send="true">OvmsDev@lists.teslaclub.hk</a>
<a class="moz-txt-link-freetext" href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="160">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a>
<a class="moz-txt-link-freetext" href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
</body>
</html>