<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Michael,<br>
<br>
Thanks for the review and the background on the otherwise useless
call. I'll make the changes and push.<br>
<br>
Sorry about the '\n'. Muscle memory from too many years of
printfs... The indentation style thing, actually, I was trying to
match what was done in the original code. Kind of bugged me too,
but I didn't want to upset things too much. <br>
<br>
Thanks again,<br>
<br>
Greg<br>
<br>
<br>
<div class="moz-cite-prefix">Michael Balzer wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2e54b940-b67b-a702-650d-caa308f74f5a@expeedo.de">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Greg,<br>
<br>
looks correct, just some general notes:<br>
<ul>
<li>Line 252: "so why are we even here?" -- because the
RxCallback() will be called again after fetching an RX buffer
to check for the other RX buffer. If no other RX and no error
occurred, the callback loop can be terminated. It may also be
that the RxCallback() loop fetches an RX that occurred after
the trigger of the current loop, so the framework will call
again after polling the intermediate RxCallback request, but
the buffer will already be empty.<br>
</li>
<li>Line 294: this should be a warning level log, also the "\n"
at the end isn't necessary for a log.</li>
<li>Code style: for readability and maintainability, please try
to adopt the general coding style (at least indentation &
line break / space conventions) of the module you're changing,
or run a formatter on your changes before committing.<br>
</li>
</ul>
Regards,<br>
Michael<br>
<br>
<br>
<div class="moz-cite-prefix">Am 11.01.2018 um 05:55 schrieb Greg
D.:<br>
</div>
<blockquote type="cite"
cite="mid:b229b09f-ef72-c564-7839-fa8a815157cd@gmail.com"> For
receive, I'd go with what I have for now, if Michael would be so
kind as to review what I have done first. <a
class="moz-txt-link-freetext"
href="https://github.com/bitsofgreg/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/mcp2515/mcp2515.cpp"
moz-do-not-send="true">https://github.com/bitsofgreg/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/mcp2515/mcp2515.cpp</a>
Hopefully he'll be back on line before I get up in the morning.
Wonderful how the Earth's spin helps with the teamwork.</blockquote>
<br>
<pre class="moz-signature" cols="160">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a>
<a class="moz-txt-link-freetext" href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
</body>
</html>