<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 20/11/17 02:49, Mark Webb-Johnson wrote:<br>
<blockquote type="cite"
cite="mid:315DAF66-F6EA-4B6F-A8D0-6341DBF7C81D@webb-johnson.net">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="">In v3, I haven’t bother with listen-only. Looking at
connections to <a href="http://api.openvehicles.com" class=""
moz-do-not-send="true">api.openvehicles.com</a>, all but 2
vehicles have feature 15=1 (and those are probably mistakes by
the end-user).</div>
</blockquote>
<br>
OK I won't worry about porting that code.<br>
<br>
<blockquote type="cite"
cite="mid:315DAF66-F6EA-4B6F-A8D0-6341DBF7C81D@webb-johnson.net">
<div class="">
<blockquote type="cite" class="">In v2 I abstracted the hardware
interactions necesary to write to the canbus into a function
void vehicle_nissanleaf_send_can_message(short id, unsigned
char length, unsigned char *data). In v3 we call
canbus::Write(const CAN_frame_t* p_frame). Do we want to add a
similar simpler "send to this buffer with this can id" method
to the canbus object? The Leaf doesn't use any of the extended
can features so a simple interface for the simple case seems
to make sense. For the moment I've implemented it within the
leaf codebase, see void
OvmsVehicleNissanLeaf::SendCanMessage(uint16_t id, uint8_t
length, uint8_t *data) in the pull request.</blockquote>
<br class="">
</div>
<div class="">No harm in adding that, if you think it is useful.
Please go ahead.</div>
</blockquote>
<br>
I've updated
<a class="moz-txt-link-freetext" href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/9">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/9</a><br>
<br>
I used method overloading, which I've previously learnt isn't as
straightforward as it is in Java. Please advise if this is an
appropriate way to add two Write methods to the canbus object.<br>
<br>
</body>
</html>