<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Tom,<div class=""><br class=""></div><div class=""><blockquote type="cite" class="">In v2 we checked whether transmit mode was enabled, I'm not seeing similar logic in the Telsa Roadster module. I've commented out the checks in the leaf code for the time being.<br class=""></blockquote><br class=""></div><div class="">In v3, I haven’t bother with listen-only. Looking at connections to <a href="http://api.openvehicles.com" class="">api.openvehicles.com</a>, all but 2 vehicles have feature 15=1 (and those are probably mistakes by the end-user).</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">In v2 I abstracted the hardware interactions necesary to write to the canbus into a function void vehicle_nissanleaf_send_can_message(short id, unsigned char length, unsigned char *data). In v3 we call canbus::Write(const CAN_frame_t* p_frame). Do we want to add a similar simpler "send to this buffer with this can id" method to the canbus object? The Leaf doesn't use any of the extended can features so a simple interface for the simple case seems to make sense. For the moment I've implemented it within the leaf codebase, see void OvmsVehicleNissanLeaf::SendCanMessage(uint16_t id, uint8_t length, uint8_t *data) in the pull request.</blockquote><br class=""></div><div class="">No harm in adding that, if you think it is useful. Please go ahead.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">I've also porting over the remote command features, I like the interface presented to the car modules to implement these. I need to wait until tomorrow to test these on a real car so haven't sent a pull request yet. I'm very close to finished on porting the leaf support!</blockquote></div><div class=""><br class=""></div><div class="">Fantastic. Tesla Roadster is at a similar state.</div><div class=""><br class=""></div><div class="">Regards, Mark </div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 19 Nov 2017, at 10:46 AM, Tom Parker <<a href="mailto:tom@carrott.org" class="">tom@carrott.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi,<br class=""><br class="">I ported over support for Gen 2 Chargers and polling for the battery Ah capacity and the "Hx" value in <a href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/9" class="">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/9</a><br class=""><br class="">3 Questions:<br class=""><br class="">In v2 we checked whether transmit mode was enabled, I'm not seeing similar logic in the Telsa Roadster module. I've commented out the checks in the leaf code for the time being.<br class=""><br class="">In v2 I abstracted the hardware interactions necesary to write to the canbus into a function void vehicle_nissanleaf_send_can_message(short id, unsigned char length, unsigned char *data). In v3 we call canbus::Write(const CAN_frame_t* p_frame). Do we want to add a similar simpler "send to this buffer with this can id" method to the canbus object? The Leaf doesn't use any of the extended can features so a simple interface for the simple case seems to make sense. For the moment I've implemented it within the leaf codebase, see void OvmsVehicleNissanLeaf::SendCanMessage(uint16_t id, uint8_t length, uint8_t *data) in the pull request.<br class=""><br class="">I've also porting over the remote command features, I like the interface presented to the car modules to implement these. I need to wait until tomorrow to test these on a real car so haven't sent a pull request yet.<br class=""><br class="">I'm very close to finished on porting the leaf support!<br class=""><br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.teslaclub.hk" class="">OvmsDev@lists.teslaclub.hk</a><br class="">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev<br class=""></div></div></blockquote></div><br class=""></div></body></html>