<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">All good. I merged it, and changed NL->KS on line 41.<div class=""><br class=""></div><div class="">Regards, Mark.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 23 Oct 2017, at 9:19 AM, Tom Parker <<a href="mailto:tom@carrott.org" class="">tom@carrott.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""><p class=""><span class="blob-code-inner"><span class="pl-s">Hi Geir,</span></span></p><p class=""><span class="blob-code-inner"><span class="pl-s">I see you've got
Soule on line 41, and you've used the NL vehicle code on line
63 of vehicle_kiasoulev.cpp.</span></span></p><p class=""><span class="blob-code-inner"><span class="pl-s">Otherwise it
looks good.</span></span></p><p class=""><span class="blob-code-inner"><span class="pl-s">I've been
porting the Leaf v2 logic with as few changes as possible. The
changes are mostly simple, replacement of can_databuffer with
d and replacing the global state variables with metrics
setters. I can still make sense of a diff between the v3 .cpp
file and the v2 .c file. Once I have full feature parity
between v2 and v3, I'll probably refactor the cpp code some.</span></span></p>
<div class="moz-cite-prefix">On 23/10/17 09:50, Geir Øyvind Vælidalo
wrote:<br class="">
</div>
<blockquote type="cite" cite="mid:3A0BB387-E6D1-4C38-89A3-34F771F55421@validalo.net" class="">Mark,
<div class=""><br class="">
</div>
<div class="">I just sent a Pull request for the initial Kia Soul
EV-stub.
<div class="">I’m still a newbie on GIT so forgive me if I make
a mess! Most of the time spent so far is setting up esp-idf
and trying to figure out GIT again 🙂</div>
<div class=""><br class="">
</div>
<div class="">Geir</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre wrap="" class="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a>
<a class="moz-txt-link-freetext" href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br class="">
</div>
_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.teslaclub.hk" class="">OvmsDev@lists.teslaclub.hk</a><br class="">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev<br class=""></div></blockquote></div><br class=""></div></body></html>