<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>I got it: texting "ACC PARAMS" with no arguments corrupts the cooling parameter.</div><div><br></div><div>Thanks Jack and Mark!<br><br><div> Tom</div></div><div><br>On Dec 7, 2014, at 6:38 PM, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net">mark@webb-johnson.net</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html charset=windows-1252">Yes, I've seen this for a while. I assumed it was something to do with the early versions, but perhaps it is still there somewhere.<div><br></div><div>Most likely cause is that the SMS interface uses 1..4 as ACC locations, using n-1 as offset from parameter #16. If an ACC location of zero is somehow getting through, then that would cause an offset of -1 and the problem.</div><div><br></div><div>I had a sniff in the code, and it seems acc_cmd_params() may be checking "if (k<0)" when it should be "if (k<=0)".</div><div><br></div><div>Regards, Mark.</div><div><br><div><div>On 8 Dec, 2014, at 10:28 am, Jack West <<a href="mailto:jackduncanwest@gmail.com">jackduncanwest@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="content-type" content="text/html; charset=utf-8"><div dir="auto"><div>I have continued to see garbage on occasion in the slot for parameter 15. I never use cool down so assume it is because of ACC. I think it might have something to do with trying to set an ACC location when you are not there. I have not been able to reproduce the problem reliably and at the moment my car is in need of repairs so I am unable to test. This from version 2.6.5 so the trouble might not be because of the update.</div><div><br></div><div>Jack<br><br></div><div><br>On Dec 7, 2014, at 4:29 PM, Tom Saxton <<a href="mailto:tom@idleloop.com">tom@idleloop.com</a>> wrote:<br><br></div><blockquote type="cite"><div>Hi Mark,</div><div><br></div><div>I upgraded to 2.6.7/TR/V2 and the car started charging immediately, Range mode at 13A, so a cool down. The car was cool, battery temp at 60F, 16C.</div><div><br></div><div>I sent a STAT message and got this reply:</div><div><br></div><div><div style="margin: 0px;">12:42:00</div><div style="margin: 0px;"> Cooldown: 16C/0C (0cycles, 53mins remain)Standard - Charging Stopped</div><div style="margin: 0px;"> SOC: 96%</div><div style="margin: 0px;"> Ideal Range: 179 mi</div><div style="margin: 0px;"> Est. Range: 160 mi</div><div style="margin: 0px;"> ODO: 42,935.8 mi</div><div style="margin: 0px;"> CAC: 149.86</div><div style="margin: 0px;"><br></div><div style="margin: 0px;">It looks like it's trying to cool the pack down to 0C.</div><div style="margin: 0px;"><br></div><div style="margin: 0px;">So, I looked at the parameters via the iOS app and found what looks like an off-by-one bug on the parameters. I see "#15 Cooldown" and "#16: ACC #1" are both long strings of encoded text. I expected to see Cooldown at 27. I definitely have one ACC location, maybe two.</div><div style="margin: 0px;"><br></div><div style="margin: 0px;">Also, it looks like there should be a line break before "Standard - Charging Stopped".</div><div style="margin: 0px;"><br></div><div style="margin: 0px;"> Tom</div></div><div><br></div><span id="OLK_SRC_BODY_SECTION"><div>On 10/20/14, 6:58 AM, "Mark Webb-Johnson" <<a href="mailto:mark@webb-johnson.net">mark@webb-johnson.net</a>> wrote:</div><div style="font-size: 14px; font-family: Calibri, sans-serif;"><br></div><div style="font-size: 14px; font-family: Calibri, sans-serif;"><meta http-equiv="Content-Type" content="text/html charset=utf-8"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Its been a while, and quite a bit has changed, so time for a new firmware.</div><div class=""><br class=""></div><div class="">Changes:</div><div class=""><br class=""></div><div class=""><ul class="MailOutline"><li class="">Twizy updates</li><li class="">Think city updates</li><li class="">TR VECE updates</li><li class="">Fix issue #135 (SMS response messed up for GPRS?, etc)</li><li class="">Fix for net_msg handling of SMS LOCK, UNLOCK, VALET, UNVALET (and others) in Tesla Roadster module</li><li class="">Make all SMS responses include the time (if possible), but add a carbits feature FEATURE_CB_SSMSTIME to allow this to be suppressed</li><li class="">Allow ACC acc_handle_msg to choose to handle a particular message</li><li class="">First implemention of net_fnbits NET_FN_CARTIME (as per <a href="http://lists.teslaclub.hk/pipermail/ovmsdev/2013-November/001819.html" class="">http://lists.teslaclub.hk/pipermail/ovmsdev/2013-November/001819.html</a>)</li></ul></div><div class=""><br class=""></div><div class="">For the NET_FN_CARTIME, this is enabled in vehicle modules by setting net_fnbits |= NET_FN_CARTIME during initialisation (see vehicle_obdii.c for an example) and then not adjusting car_time at all. The car_parktime can be set as normal (using car_time as a reference). This is completely untested (I’ve somehow lost GSM connectivity to my workbench in the last week or two, so this is proving hard for me to test).</div><div class=""><br class=""></div><div class="">The logic for NET_FN_CARTIME is implemented in three places:</div><div class=""><br class=""></div><div class=""><ol class="MailOutline"><li class="">The vehicle.c implements initialisation of car_time.</li><li class="">The led.c implements an interrupt to increment car_time every second. As we treat 104.8576ms as 105ms, we are 0.1424ms inaccurate for each clock tick, which may build up over time (but is still more accurate than the previous approach).</li><li class="">The net.c implements handling the response to +CCLK polls, and adjusts car_time and car_parktime if necessary.</li></ol></div><div class=""><br class=""></div><div class="">I’d appreciate it if someone with better connectivity on their workbench could help test this, and fix as appropriate. Hopefully we can get any bugs in this worked out over the next few days and when it is working change the vehicle modules to use it and then cut a firmware v2.6.7.</div><div class=""><br class=""></div><div class="">Regards, Mark.</div><div class=""><br class=""></div></div></div><font face="Calibri,sans-serif" style="font-size: 14px;">_______________________________________________
OvmsDev mailing list
</font><a href="mailto:OvmsDev@lists.teslaclub.hk" style="font-size: 14px; font-family: Calibri, sans-serif;">OvmsDev@lists.teslaclub.hk</a>
<a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" style="font-size: 14px; font-family: Calibri, sans-serif;">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</span>
</blockquote><blockquote type="cite"><span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a></span><br><span><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a></span><br></blockquote></div>_______________________________________________<br>OvmsDev mailing list<br><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></blockquote></div><br></div></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a></span><br><span><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a></span><br></div></blockquote></body></html>