<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:12pt"><div class="" style=""><span style="font-size: 12pt;">I have been testing the logging for the mitsubishi and noticed a problem with it - no matter if I was charging or driving the log was always showing driving. </span><br></div><div class="" style="">I have been looking at the code and I think I found the problem. If I understand this correctly <span style="font-size: 12pt;" class="">in vehicle_mitsubishi_ticker1 function in vehicle_mitsubishi.c file the car_doors1bits.CarON is set depending on wheather there is CAN bus communication. This is unfortunate since the car_doors1bits.CarON (via CAR_IS_ON) is used in the logging.c to determine if the car is "driving"... and if it is, then it is not "charging". </span></div><div class="" style="color: rgb(0, 0, 0);
font-size: 12pt; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;"><span style="font-size: 12pt;" class=""><br class="" style=""></span></div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;">I am not sure what the best solution would be:</div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;"> - to set the <span style="font-size: 12pt;" class="">car_doors1bits.CarON to 0 if the car is charging or</span></div><div class="" style="color: rgb(0, 0, 0); font-size: 12pt; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande',
sans-serif; font-style: normal; background-color: transparent;"><span style="font-size: 12pt;" class=""> - to refactore the logging code to prefer the CAR_IS_CHARGING and test for it first in the various if/else statements.</span></div><div class="" style="color: rgb(0, 0, 0); font-size: 12pt; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;"><span style="font-size: 12pt;" class=""><br></span></div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;">I have not been able to build and test any of this yet. </div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color:
transparent;"><br></div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;">Any comments, ideas, suggestions on how to solve this?</div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;"><br></div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;">Nikolay</div><div class="" style=""><br class="" style=""></div><div class="" style=""> </div></div></body></html>