<div dir="ltr"><div>Is there an simple explanation somewhere of the change to the polling system?<br><br></div>Matt Beard<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 January 2014 12:11, Mark Webb-Johnson <span dir="ltr"><<a href="mailto:mark@webb-johnson.net" target="_blank">mark@webb-johnson.net</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Michael,<div><br></div><div>Yep, that’s it.</div><div><br></div><div>Problem is OVMS_POLLER is a compile-time definition, so it must be shared by all cars in the configuration. I’ve re-worked it slightly to call the poll0 function even there is no poll list defined:</div>

<div><br></div><div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>diff --git a/vehicle/OVMS.X/vehicle.c b/vehicle/OVMS.X/vehicle.c</div><div>index 9c1e9d9..a706bf1 100644</div><div>--- a/vehicle/OVMS.X/vehicle.c</div>

<div>+++ b/vehicle/OVMS.X/vehicle.c</div><div>@@ -295,15 +295,21 @@ void high_isr(void)</div><div class="im"><div>     can_databuffer[7] = RXB0D7;</div><div>     RXB0CONbits.RXFUL = 0; // All bytes read, Clear flag</div>
</div>
<div> #ifdef OVMS_POLLER</div><div>-    if ((vehicle_poll_plist != NULL)&&</div><div>-        (can_id >= vehicle_poll_moduleid_low)&&</div><div>-        (can_id <= vehicle_poll_moduleid_high))</div>
<div>
+    if (vehicle_poll_plist != NULL)</div><div>       {</div><div>-      if (vehicle_poll_poll0())</div><div>+      if ((can_id >= vehicle_poll_moduleid_low)&&</div><div>+          (can_id <= vehicle_poll_moduleid_high))</div>

<div>         {</div><div>-        vehicle_fn_poll0();</div><div>+        if (vehicle_poll_poll0())</div><div>+          {</div><div>+          vehicle_fn_poll0();</div><div>+          }</div><div>         }</div><div>       }</div>

<div>+    else</div><div>+      {</div><div>+      vehicle_fn_poll0();</div><div>+      }</div><div> #else // #ifdef OVMS_POLLER</div><div>     vehicle_fn_poll0();</div><div> #endif //#ifdef OVMS_POLLER</div></div></blockquote>

</div><div><br></div><div>I hope this fixes it.</div><div><br></div><div>Thomas: Can you try to build this version (it is in github master now).</div><div><br></div><div>Regards, Mark.</div><div><br><div><div><div class="h5">

<div>On 23 Jan, 2014, at 4:29 pm, Michael Balzer <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>> wrote:</div><br></div></div><blockquote type="cite"><div><div class="h5">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Mark,<br>
    <br>
    if the Mitsubishi code does not use the new polling hooks, poll0()
    will not be called if the polling code is compiled in.<br>
    <br>
    I had the same problem for the Twizy, that's why I introduced the
    OVMS_POLLER compiler switch.<br>
    <br>
    Regards,<br>
    Michael<br>
    <br>
    <br>
    <div>Am 22.01.2014 02:18, schrieb Mark
      Webb-Johnson:<br>
    </div>
    <blockquote type="cite">
      
      Thomas, 
      <div><br>
      </div>
      <div>Strange. So far, I see 4 cars using 2.6.2, but only one
        (presumably yours) is showing authentication errors.</div>
      <div><br>
      </div>
      <div>I also can't see any changes to the vehicle_mitsubishi.c code
        that would cause poll0 to stop working. It is certainly working
        in other vehicle modules.<br>
        <div><br>
        </div>
        <div>I'll keep looking, but would be grateful if you could try
          to narrow down the poll0 problem.</div>
        <div><br>
        </div>
        <div>Regards, Mark.</div>
        <div><br>
          <div>
            <div>On 22 Jan, 2014, at 5:00 am, Thomas Bergo <<a href="mailto:thomas.bergo@gmail.com" target="_blank">thomas.bergo@gmail.com</a>>
              wrote:</div>
            <br>
            <blockquote type="cite">
              <div dir="ltr">Mark,
                <div><br>
                </div>
                <div>Was testing the new 2.6.2 code on i-Miev today. </div>
                <div><br>
                </div>
                <div>Two observations:</div>
                <div>- Lots of restarts and "Vehicle authentication
                  failed" messages in the iOS app </div>
                <div>- No CAN bus messages form PID in poll0, while
                  messages in poll1 is working OK.</div>
                <div><br>
                </div>
                <div>Programmed the OVMS module with a version, and
                  verified that the module was OK.</div>
                <div><br>
                </div>
                <div>Regards, Thomas</div>
              </div>
              <div class="gmail_extra"><br>
                <br>
                <div class="gmail_quote">2013/10/30 Thomas Bergo <span dir="ltr"><<a href="mailto:thomas.bergo@gmail.com" target="_blank">thomas.bergo@gmail.com</a>></span><br>
                  <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                    <div dir="ltr">Matt,
                      <div><br>
                      </div>
                      <div>Please report back when you have done some
                        testing on the QC.</div>
                      <div><br>
                      </div>
                      <div>If the car report 0A while QC, the current
                        code will not detect that we are charging. So
                        then we need to rely on the estimated range
                        reported as 255 to detecting that the car is QC.</div>
                      <div><br>
                      </div>
                      <div>Regards, Thomas </div>
                    </div>
                    <div>
                      <div>
                        <div class="gmail_extra"><br>
                          <br>
                          <div class="gmail_quote">2013/10/30 Matt Beard
                            OVMS <span dir="ltr"><<a href="mailto:smvo@mxf.org.uk" target="_blank">smvo@mxf.org.uk</a>></span><br>
                            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                              <div dir="ltr">
                                <div>
                                  <div>
                                    <div>Hi Thomas,<br>
                                      <br>
                                    </div>
                                    During QC you don't get valid values
                                    reported in 0x389 - it seems to be
                                    constant 255V, 0A during QC.<br>
                                    <br>
                                  </div>
                                  My code is relying on the fact that
                                  the estimated range only ever seems to
                                  be reported as 255 during QC (except
                                  for the first few messages at startup,
                                  but those are easy to filter out). In
                                  my testing so far this seems to work
                                  for detecting the start and end of QC.
                                  I am going to be doing 3 more tests
                                  today with my latest code and will
                                  report back later.<span><font color="#888888"><br>
                                      <br>
                                    </font></span></div>
                                <span><font color="#888888">Matt<br>
                                    <br>
                                  </font></span></div>
                              <div class="gmail_extra"><br>
                                <br>
                                <div class="gmail_quote">
                                  <div>On 27 October 2013 20:13, Thomas
                                    Bergo <span dir="ltr"><<a href="mailto:thomas.bergo@gmail.com" target="_blank">thomas.bergo@gmail.com</a>></span>
                                    wrote:<br>
                                  </div>
                                  <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                    <div>
                                      <div dir="ltr">Hi Matt
                                        <div><br>
                                        </div>
                                        <div>I have started to look into
                                          the QC code. And i have one
                                          concern. </div>
                                        <div>
                                          Have you seen if the voltage
                                          and charging current (PID
                                          0x389) is reported during QC? </div>
                                        <div>If not, we are not able to
                                          detect that the car is
                                          charging during QC with
                                          current code.</div>
                                        <span><font color="#888888">
                                            <div><br>
                                            </div>
                                            <div>Thomas</div>
                                            <div class="gmail_extra"><br>
                                              <br>
                                            </div>
                                          </font></span></div>
                                      <br>
                                    </div>
                                    <div>_______________________________________________<br>
                                      OvmsDev mailing list<br>
                                      <a href="mailto:OvmsDev@lists.teslaclub.hk" target="_blank">OvmsDev@lists.teslaclub.hk</a><br>
                                      <a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br>
                                      <br>
                                    </div>
                                  </blockquote>
                                </div>
                                <br>
                              </div>
                              <br>
_______________________________________________<br>
                              OvmsDev mailing list<br>
                              <a href="mailto:OvmsDev@lists.teslaclub.hk" target="_blank">OvmsDev@lists.teslaclub.hk</a><br>
                              <a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br>
                              <br>
                            </blockquote>
                          </div>
                          <br>
                        </div>
                      </div>
                    </div>
                  </blockquote>
                </div>
                <br>
              </div>
              _______________________________________________<br>
              OvmsDev mailing list<br>
              <a href="mailto:OvmsDev@lists.teslaclub.hk" target="_blank">OvmsDev@lists.teslaclub.hk</a><br>
              <a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br>
            </blockquote>
          </div>
          <br>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
OvmsDev mailing list
<a href="mailto:OvmsDev@lists.teslaclub.hk" target="_blank">OvmsDev@lists.teslaclub.hk</a>
<a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a>
</pre>
    </blockquote>
    <br>
    <pre cols="72">-- 
Michael Balzer * Paradestr. 8 * D-42107 Wuppertal
Fon 0202 / 272 2201 * Handy 0176 / 206 989 26
</pre>
  </div>

</div></div><span><dexter.vcf></span>_______________________________________________<div class="im"><br>OvmsDev mailing list<br><a href="mailto:OvmsDev@lists.teslaclub.hk" target="_blank">OvmsDev@lists.teslaclub.hk</a><br>

<a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></div></blockquote></div><br></div></div><br>_______________________________________________<br>


OvmsDev mailing list<br>
<a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br>
<a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br>
<br></blockquote></div><br></div>