<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div>I found a bug (the usual byte overflow without an integer cast on an 8 bit processor) in the code to set timezone. It only appeared with timezones >4 hours from GMT.<div><br></div><div>The timed charge itself seemed to work, just at the wrong time :-(</div><div><br></div><div>I've committed this fix to github, plus a few other minor fixes, and will test in my car tomorrow.</div><div><br></div><div>Regards, Mark.</div><div><br><div><div><div>On 23 Sep, 2013, at 2:47 PM, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net">mark@webb-johnson.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Curt,<div><br></div><div>If, for example, you are 5 hours west of GMT, you should set timezone to -05:00. That appears to be what you have set.</div><div><br></div><div>After setting a 'ACC PARAMS CHARGEBY 08:00', the 'ACC STAT' should show '08:00:00'. If it doesn't, something is wrong.</div><div><br></div><div>Can you also set the chargelimit (even if it is the same as the wall limit) - that is required in order to be able to estimate charge time.</div><div><br></div><div>Regards, Mark.</div><div><br></div><div><div>On 23 Sep, 2013, at 5:17 AM, Curt Harpold <<a href="mailto:curt.harpold@gmail.com">curt.harpold@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Mark,<div><br></div><div style="">Sorry for all of the emails, I just figured you would want to know how testing is going.</div><div style=""><br></div><div style="">Never mind the earlier ones - TPMS data has re-appeared. I think that I needed to do a drive after the module was re-installed to get the data read in (not sure about that). I have opted in to charge logging, so you can see what is happening.</div>
<div style=""><br></div><div style="">
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">Output of "SMS STAT" for the specified location</span><br></div><div style="">
<span style="font-family: Helvetica; font-size: medium; ">STAT?</span><div style="font-family: Helvetica; font-size: medium; "><div>Standard - Charging</div><div> 232V/40A</div><div> Full: 88 mins</div>
<div> SOC: 73%</div><div> Ideal Range: 133 mi</div><div> Est. Range: 125 mi</div><div> ODO: 22,715.3 mi</div><div> CAC: 147.76</div></div><div style="font-family: Helvetica; font-size: medium; "><br></div><div style="font-family: Helvetica; font-size: medium; ">
ACC STAT</div><div><div style="font-family: Helvetica; font-size: medium; ">ACC Status #1</div><div style="font-family: Helvetica; font-size: medium; "> 39.072536, -77.131168</div><div style="font-family: Helvetica; font-size: medium; ">
Enabled</div><div style="font-family: Helvetica; font-size: medium; "> Cooldown</div><div style="font-family: Helvetica; font-size: medium; "> Charge by time 03:44:00</div><div style="font-family: Helvetica; font-size: medium; ">
Mode: standard (0A)</div><div style="font-family: Helvetica; font-size: medium; "><br></div><div style="font-family: Helvetica; font-size: medium; ">
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">Your vehicle id</span><br></div><div style="font-family: Helvetica; font-size: medium; ">
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">ROADSTER76</span></div><div style="font-family: Helvetica; font-size: medium; ">
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)"><br></span></div><div style="font-family: Helvetica; font-size: medium; ">
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">Output of base64 parameter string (from the cellphone app)</span><span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)"><br>
</span></div><div><span style="background-color:rgb(250,250,250)"><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">AqkrEWe+Gt4BQwAA4AAAAAAAAAA=</font><br></span></div></div><div><span style="background-color:rgb(250,250,250)"><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br>
</font></span></div><div>
<ul style="font-size:13px;padding:0px;color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;background-color:rgb(250,250,250)"><li style="padding:0px;list-style:disc outside">Date/Time you entered the ACC location (with timezone)</li>
<li style="padding:0px;list-style:disc outside">22 September 2013 15:41 EST</li></ul><div>
<ul style="font-size:13px;padding:0px;color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;background-color:rgb(250,250,250)"><li style="padding:0px;list-style:disc outside">Date/Time you plugged in at the ACC location (with timezone)</li>
<li style="padding:0px;list-style:disc outside">22 September 2013 approx 16:45 EST</li></ul><div>
<ul style="font-size:13px;padding:0px;color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;background-color:rgb(250,250,250)"><li style="padding:0px;list-style:disc outside">In the smartphone app, call up the Features and Parameters screens (so the server logs those, and I can check)</li>
<li>Done.</li></ul><div>
<span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">Description of the problem you have</span><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br>
</font></div></div></div></div><div style=""><span style="color:rgb(51,51,51);font-family:Verdana,Arial,Tahoma,Calibri,Geneva,sans-serif;font-size:13px;background-color:rgb(250,250,250)">I set the ACC params for Cooldown, Chargeby 08:00, and Standard mode. When I plugged in, the charge started immediately, with no </span><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">cooldown phase (probably expected, since the battery is already below the threshold). Further attempt to request a cooldown made no change. Standard mode charge proceeded, even though I would have expected a timed charge to start some time tomorrow morning (and the STAT? command now reports time to full at just 88 minutes).</font></div>
<div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br></font></div><div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">Also, I set CHARGEBY for 08:00, but the ACC STAT return seems to indicate it is set for 44 minutes after the time specified. If it were working, it would be late.</font></div>
<div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br></font></div><div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">Now that I look at it again, I don't understand the time setting at all. I followed your insructions to use a leading "-" as I am West of GMT. I would expect the reported CHARGEBY time to be either 08:00 (local) or 13:00 (GMT), but I'm seeing 03:44.</font></div>
<div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br></font></div><div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">Many thanks - will try to help with any testing you need in a timely manner.</font></div>
<div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif"><br></font></div><div style=""><font color="#333333" face="Verdana, Arial, Tahoma, Calibri, Geneva, sans-serif">......curt</font></div>
</div></div>
_______________________________________________<br>OvmsDev mailing list<br><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></blockquote></div><br></div></blockquote></div><br></div></div></body></html>