<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div>If the cars have some messages in common, then best to use one module for both and switch the vehicle type either specifically in config (carbits) or dynamically at runtime (by looking at the messages). That is the way we handled the differences between v1 and v2 Tesla Roadsters. For the roadster, we looked at the VIN message, and automatically switch v1 or v2 support based on the vehicle type identified by the VIN.<div><br></div><div>In that case, I think vehicle_thinkcity.* is fine, but vehicle id TCMS and TCEL would differentiate the two. The vehicle module identified can simply be "TC". The vehicle type is a variable in memory, and purely informative.</div><div><br></div><div>Let's try it that way to start, but if the modules really differ too much then we can split later. Perhaps start with just one variant?</div><div><br></div><div>Regards, Mark.<br><div><br><div><div>On 28 Dec, 2012, at 9:57 AM, Nikolay Shishkov wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Thanks Mark, </span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span>I may need two stubs - one for the model with Zebra (molten salt) batteries, and the other one for the enerdel li-ion batteries.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><span>They have different battery systems with different can bus messages, and I think it may be easier to have the code separate?</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;">Most of the other systems are the same...so some kind of inheritance or common stub maybe more appropriate?</div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: 'times new roman', 'new york', times, serif; background-color: transparent; font-style: normal;">Nikolay</div><div><br></div> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"> <div dir="ltr"> <font size="2" face="Arial"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Mark Webb-Johnson
<<a href="mailto:mark@webb-johnson.net">mark@webb-johnson.net</a>><br> <b><span style="font-weight: bold;">To:</span></b> OVMS Developers <<a href="mailto:ovmsdev@lists.teslaclub.hk">ovmsdev@lists.teslaclub.hk</a>> <br> <b><span style="font-weight: bold;">Sent:</span></b> Friday, December 28, 2012 1:47 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> [Ovmsdev] Think City EV<br> </font> </div> <br>
<meta http-equiv="x-dns-prefetch-control" content="off"><div id="yiv456474722"><div><div><br></div>Nikolay,<div><br></div><div>I'll create the stub vehicle code for Think City EV for you.</div><div><br></div><div>We'll need a vehicle name and ID. I suggest:</div><div><br></div><blockquote class="yiv456474722webkit-indent-blockquote" style="margin:0 0 0 40px;border:none;padding:0px;"><div>Module:<span class="yiv456474722Apple-tab-span" style="white-space:pre;"> </span>vehicle_thinkcity.*</div><div>ID:<span class="yiv456474722Apple-tab-span" style="white-space:pre;"> </span>TCEV</div></blockquote><div><br></div><div>Is that ok? If so, I'll create it today.</div><div><br></div><div>Regards, Mark.</div><div><br></div></div></div><meta http-equiv="x-dns-prefetch-control" content="on"><br>_______________________________________________<br>OvmsDev mailing list<br><a ymailto="mailto:OvmsDev@lists.teslaclub.hk" href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev" target="_blank">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br><br><br> </div> </div> </div></div>_______________________________________________<br>OvmsDev mailing list<br><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br>http://lists.teslaclub.hk/mailman/listinfo/ovmsdev<br></blockquote></div><br></div></div></body></html>