<html><head></head><body bgcolor="#FFFFFF"><div>Michael and Mark,</div><div><br></div><div>I'm glad you were able to test this out and confirm Michael. My car was too warm to test the heating cycle today. I'm proposing the following and will test it out tonight or in the morning (as soon as my car chills out).</div><div><br></div><div>can.c</div><div><br></div><div>Line #243</div><div>Case 0x96:</div><div> if ((car_charging) && !((can_databuffer[1] & 0x10) || (car_chargestate == 0x0f)))</div><div> car_stopped = 1;</div><div> car_charging = ((can_databuffer [1] & 0x10) || (car_chargestate == 0x0f));</div><div><br></div><div>And</div><div><br></div><div>Line #229</div><div>case 0x95:</div><div>if (car_chargestate = = 0x0f) // heating state is treated as charging</div><div> car_charging = 1;</div><div><br></div><div>Jack</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br>On Feb 14, 2012, at 3:43 AM, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net">mark@webb-johnson.net</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><div><br></div>Bizarre. I guess they don't count it as 'charging' until current is going into the pack directly (as opposed to coming out of the wall).<div><br></div><div>I converted your logs (thanks) to roadster_can.pl compatible format, and it all looks quite clean. There are some very strange message states (in particular, the percentage jumps all over the place), but I don't see any unexpected charging->notcharging->charging transitions. Charging is OFF for the whole of the 0-49 log, and only goes on after pre-heat in the 100 log.</div><div><br></div><div>The 0-49 log shows:</div><div><br></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;"><div><div>0.0 100 95 0D 07 64 A4 01 16 00 ->VDS Charger v1.5 (preparing-to-charge) (conn-pwr-cable) (standard)</div><div> ...</div></div><div>0.0 100 96 2C 00 02 21 38 00 00 ->VDS Doors (l-door: closed) (r-door: closed) (chargeport: open) (pilot: true) (charging: false) (bits 2C)</div><div><div>0.0 100 95 0F 0B 31 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div></div><div>0.0 100 95 0F 0B 00 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div><div>0.0 100 95 0F 0B 18 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 00 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 18 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 31 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 15 03 64 A4 01 16 00 ->VDS Charger v1.5 (stopped-charging) (by-request) (standard)</div></div><div>0.0 100 96 2C 00 02 21 38 00 00 ->VDS Doors (l-door: closed) (r-door: closed) (chargeport: open) (pilot: true) (charging: false) (bits 2C)</div></blockquote><div><br></div><div>The 100 log shows:</div><div><br></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;"><div><div>0.0 100 95 15 03 64 A4 01 16 00 ->VDS Charger v1.5 (stopped-charging) (by-request) (standard)</div><div>0.0 100 95 0F 0B 31 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 00 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 31 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 00 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 00 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 31 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 95 0F 0B 63 A4 01 16 00 ->VDS Charger v1.5 (??state?? 15) (??sub-state?? 11) (standard)</div><div>0.0 100 96 2C 00 02 21 38 00 00 ->VDS Doors (l-door: closed) (r-door: closed) (chargeport: open) (pilot: true) (charging: false) (bits 2C)</div><div>0.0 100 95 0D 01 64 A4 01 16 00 ->VDS Charger v1.5 (preparing-to-charge) (??sub-state?? 1) (standard)</div><div>0.0 100 96 2C 00 02 21 38 00 00 ->VDS Doors (l-door: closed) (r-door: closed) (chargeport: open) (pilot: true) (charging: false) (bits 2C)</div><div>0.0 100 95 01 05 64 A4 01 16 00 ->VDS Charger v1.5 (charging) (??sub-state?? 5) (standard)</div><div>0.0 100 96 3C 00 02 21 38 00 00 ->VDS Doors (l-door: closed) (r-door: closed) (chargeport: open) (pilot: true) (charging: true) (bits 3C)</div><div>0.0 100 95 01 05 64 A4 01 16 00 ->VDS Charger v1.5 (charging) (??sub-state?? 5) (standard)</div></div></blockquote><div><br></div><div>[ side note - it seems the pilot does go false at some points in your logs ]</div><div><br></div><div>Regards, Mark.</div><div><br><div><div>On 14 Feb, 2012, at 7:01 PM, Michael Stegen wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Mark, Jack,<br><br>I can confirm that the charging bit is not set when pre-heating the battery.<br>It's only set when it goes from pre-heating to charging.<br><br>Maybe we should just look at the State (0x95) instead of charging bit (0x96) and state.<br><br>I have uploaded my logfiles fom when i did the test here:<br><a href="http://www.stegen.com/pub/bat_heating.rar">http://www.stegen.com/pub/bat_heating.rar</a><br><br>Inside the rar archive are two logfiles, one pre-heats till 49% then i press stop from the VDS.<br>The otherone pre-heats till 100%, and then the charging begins.<br><br>Note that the "preparing to charge" state is also entered after the pre-heating ended and before the actual charging starts.<br><br>-Michael<br><br><br><br><br><br><br><br>Op 14-2-2012 4:01, Mark Webb-Johnson schreef:<br><blockquote type="cite">Urgh.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I think we really need to get a good trace of what you are seeing.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Is it possible for you to run the 1.2.0-rc3 code in the car, using 202.52.42.80 server, do a full charge (including pre-heat), then let me know UTC time it started? If possible, check up on it with an App during the charge (when an App is connected, the car reports in once every minute - otherwise only once every ten minutes). I have a full log running on the development server at the moment, and 1.2.0 code sends the detailed charging bytes as well as the summary status text.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Regards, Mark.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On 14 Feb 2012, at 2:22 AM, Jack West wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Mark,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">One possibility that might explain what I saw:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">In heating substate the car does not turn on b4 of B2 in 0x96. Therefore logic does not see the car as charging when in the heating state so flags are not set, etc.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I'll look into this in more detail tonight.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Jack<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">OvmsDev mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></blockquote></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">OvmsDev mailing list<br></blockquote><blockquote type="cite"><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br></blockquote><blockquote type="cite"><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><br><br>-- <br>Stegen Electronics<br>Kwartslaan 95<br>3162 RD Rhoon<br>The Netherlands<br><br>Tel: +31 10-5016960<br>Skype: <a href="http://stegen.com">stegen.com</a><br><a href="http://www.stegen.com">www.stegen.com</a><br><br>_______________________________________________<br>OvmsDev mailing list<br><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a><br><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a><br></div></blockquote></div><br></div></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>OvmsDev mailing list</span><br><span><a href="mailto:OvmsDev@lists.teslaclub.hk">OvmsDev@lists.teslaclub.hk</a></span><br><span><a href="http://lists.teslaclub.hk/mailman/listinfo/ovmsdev">http://lists.teslaclub.hk/mailman/listinfo/ovmsdev</a></span><br></div></blockquote></body></html>