[Ovmsdev] Reducing wifi/netmanager log messages

Stephen Casner casner at acm.org
Thu Jan 17 07:14:03 HKT 2019


I thought that skipping the netif_set_default() and > SetDNSServer()
calls would be OK there because they should be called when the
priority interface (pri) changes.  This worked for me.  It was a
simplification to avoid having to make a separe check inside the DNS
code to suppress its messages when DNS did not change.

Now, I admit that comparing interface object addresses could give a
false result if the objects come and go, but again I thought that did
not happen here.  Do you know why this would be different for your
situation compared to mine?

                                                        -- Steve

On Wed, 16 Jan 2019, Michael Balzer wrote:

> Steve,
> I think you broke something, I'm now losing connectivity after changing from wifi to modem or back.
> On a first quick glance, your change on OvmsNetManager::PrioritiseAndIndicate() looks suspicious to me, as the return skips the netif_set_default() and
> SetDNSServer() calls.
> Regards,
> Michael

More information about the OvmsDev mailing list