[Ovmsdev] Command prompt in secure mode
mark at webb-johnson.net
Sun Mar 18 19:55:04 HKT 2018
I tried not changing colours at all. Just leave that at whatever the terminal program has chosen.
Committed for people to look at. Again, just a proposal - feel free to play.
> On 18 Mar 2018, at 4:35 PM, Mark Webb-Johnson <mark at webb-johnson.net> wrote:
> My $0.02 is I like the “OVMS >” vs “OVMS #” (very clear), but the red colour doesn’t do it for me.
> In fact, in general we have green for OK and red for ERROR, which is the same for the ESP_LOG messages.
> So, how about leave both consoles green colour, or just plain white?
> Regards, Mark.
>> On 18 Mar 2018, at 2:51 PM, Greg D. <gregd2350 at gmail.com> wrote:
>> Hi Steve,
>> Like the new prompt, not so convinced about the color. Being color
>> blind, it's a lot more of a nuisance than it's worth, especially when
>> there is such a variability in displays. And, it's not like we're
>> accessing something so highly sensitive that we need blinking fonts,
>> warning claxons, and colored text. My $.02, keep the pound sign, leave
>> the color the same.
>> Stephen Casner wrote:
>>> At Mark's request I have implemented a change to the command prompt
>>> after switching to secure mode:
>>> OVMS > ena
>>> Secure mode
>>> OVMS #
>>> As implemented in this commit, the color also changes from green to
>>> red, but that is only a proposal. I also looked at blue, but on my
>>> terminal it's not so distinct from black. If preferred, we can have
>>> both modes be green.
>>> Actually, as I thought about this, I wondered whether our console
>>> welcome banner and prompt should be different from green since all the
>>> info-level log messages are green. But there are not many ANSI color
>>> choices and they don't look the same on all terminals, so we can't get
>>> carried away with this.
>>> -- Steve
>>> OvmsDev mailing list
>>> OvmsDev at lists.teslaclub.hk
>> OvmsDev mailing list
>> OvmsDev at lists.teslaclub.hk
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
More information about the OvmsDev