[Ovmsdev] Macros MIN and MAX

[Stephen Casner]

Michael,

Attached is the compilation log with v3.0 so you can see the include
chain.  Certainly this can be managed with #ifndef / #undef; I added
#undef temporarily to make the warnings go away, but I thought there
might be a cleaner solution.

I'm exploring v3.0 at Mark's request so that we may be able to include
the hardware module with additional RAM.  My first step was just to
work out the compilation issues.  My task is to figure out how to
implement or replace the "module memory" and "module tasks" commands
that I implemented before with extra code added to esp-idf.  I have
not explored the SD card issues, but Mark has reported earlier on his
tests with v3.0 and the alternative hardware module.

                                                        -- Steve

On Thu, 4 Jan 2018, Michael Balzer wrote:

> Stephen,
>
> sys/param.h was not included previously. As the definitions match, I
> can use those. Or add an #ifndef / #undef.
>
> As you're compiling with v3 already: are the SD card issues solved
> with that release?
>
> Regards,
> Michael
>
>
> Am 04.01.2018 um 22:01 schrieb Stephen Casner:
> > Michael and Geir,
> >
> > Can you please see whether the definitions of MIN and MAX in your
> > files are needed?  These macros are defined in:
> >
> > esp-idf/components/newlib/include/sys/param.h
> >
> > which gets included from ovms_config.h and perhaps other places.
> >
> > When I'm compiling with release v3.0 the redefinition of these macros
> > shows up as a warning.  It would be possible to ignore the warning and
> > it might also be possible to turn off the warnings by changing the
> > configuration, but if the definitions are not needed this would be
> > cleaner.
> >
> >                                                         -- Steve
> > _______________________________________________
> > OvmsDev mailing list
> > OvmsDev at lists.teslaclub.hk
> > http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>
> --
> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
>
>
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>
>