[Ovmsdev] Crash debugging

[Michael Balzer]

Mystery solved: there is a .editorconfig file in the esp-idf root directory which my editor (kate) automatically uses, sadly without telling me or showing in
the config menu.

Obviously, the last one who worked on the two files affected used an editor that doesn't use that scheme.

Regards,
Michael


Am 09.04.2018 um 04:23 schrieb Mark Webb-Johnson:
> I use Atom, which ships by default with the ‘whitespace’ package. That removes trailing whitespaces.
>
> Did a quick check in our project, and we have it in 10 files in main/ - mostly whitespace on blank lines (which my editor is set to NOT remove - but I think it should).
>
> In our own project, I think we should in general remove this. But, as Steven says, better to do it as a separate commit. Mea culpa.
>
> Regards, Mark.
>
>> On 9 Apr 2018, at 1:20 AM, Michael Balzer <dexter at expeedo.de> wrote:
>>
>> Stephen,
>>
>> I don't care about trailing whitespace, but I know what you mean. I usually set my diff options to "-b" and "core.whitespace" to "-trailing-space" so git also
>> doesn't care.
>>
>> My editor is set to "do not remove trailing whitespace", but you're right, somehow the trailing ws in Kconfig and xtensa_api.h have been removed. Strange, I
>> can't explain that… maybe a git feature I don't know about?
>>
>> Regards,
>> Michael
>>
>>
>> Am 08.04.2018 um 18:35 schrieb Stephen Casner:
>>> Michael,
>>>
>>> I just took a quick look at the diff.  There are many lines changed
>>> because trailing whitespace was removed, presumably as an automatic
>>> action by your editor.  Is that something you can configure it not to
>>> do?
>>>
>>> I noticed the same phenomenon on some of Mark's recent commits as well,
>>> when the files being committed were ones that he had created/edited
>>> before, so perhaps you and he are using a new editor or its policy has
>>> changed.
>>>
>>> I don't like trailing whitespace, and I am careful to avoid it as I
>>> write code.  However, I also take extra effort to avoid removing any
>>> existing trailing whitespace (or make other unrelated changes like
>>> comment fixes) as part of committing a change, especially for source
>>> that isn't mine.  I sometimes make separate commits with just those
>>> nonfunctional changes.  This is to keep the annotation log meaningful.
>>>
>>> I don't mean this as a major criticism, just a question.
>>>
>>>                                                        -- Steve
>>> _______________________________________________
>>> OvmsDev mailing list
>>> OvmsDev at lists.openvehicles.com
>>> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
>> -- 
>> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
>> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
>>
>>
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.openvehicles.com
>> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26