[Ovmsdev] Leaf Updates

Tom Parker tom at carrott.org
Sat Dec 2 17:43:43 HKT 2017

On 27/11/17 13:50, Mark Webb-Johnson wrote:
> For your canbus::Write, the approach is reasonable and useful. But, 
> you are missing the message type (standard or extended). You are using 
> uint16_t for the id, so only support standard. Perhaps change the name 
> to canbus::WriteStandard(…), and also have a 
> canbus::WriteExtended(uint32_t id, …)?

I renamed it WriteStandard and added a similar WriteExtended. I tested 
the WriteExtended and it seems to work on my desktop can bus setup. I 
haven't tried with anything else.

> Regarding the OvmsVehicleNissanLeaf Ticker functions, you don’t need 
> to register the event for these. Tickers for 1, 10, 60, 300, 600 and 
> 3600 are already implemented in the base class. You just need to make 
> a void TickerXXX(uint32_t ticker) function in your code, and it will 
> get called appropriately. Have a look at vehicle_demo.{h,cpp} for an 
> example.

Nice, I've updated them.

See https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/9

More information about the OvmsDev mailing list