[Ovmsdev] sprintf / crashes

Mark Webb-Johnson mark at webb-johnson.net
Wed Jan 2 09:17:28 HKT 2013


Michael,

I had a visual review of this, and it _seems_ ok. I haven't put it in my car yet, because I'm leaving on a short overseas trip and need to make sure I have the ability to keep an eye on my car while I'm gone. I'll load the new firmware into my car when I get back at the weekend.

I really like your debug_crash*, CHECKPOINT and reporting to server as a historical record system. It would be good to take this out of OVMS_DIAGMODULE and make this a standard feature to allow us to see what is going on. On the report to server, though, I think it would be useful to add the firmware version so we can correlate crashes across different firmwares. For the iOS App, a while ago I added testflightapp to it - which centrally reports every single app crash - that was invaluable in getting the app more stable and dealing with both common and edge cases.

Regards, Mark.

On 30 Dec, 2012, at 10:42 PM, Michael Balzer wrote:

> Mark,
> 
> could you please audit & test this?
> 
> https://github.com/markwj/Open-Vehicle-Monitoring-System/commit/ad17c2662942536bc391cee282debbfcdd2ae2f5
> 
> I've reworked most of the complex sprintf() calls in the net and net_msg modules now. I also added a simple crash debug & checkpoint utility to be able to measure the effect and possibly narrow down remaining occurrences. It seems I've gained a lot of stability, had only two watchdog timeouts during the last week, no stack problems at all.
> 
> I hesitate to merge into the master because I currently have link / connectivity problems, especially during driving. I introduced a GPS logging to optimize my antenna positions and managed to get some really nice tracks three days ago, so I don't think this is related to my changes... but I'm not 100% sure. I tried different antenna positions and another GSM network, but the connection keeps dropping when moving the car, and GPS position updates need minutes. Could be weather conditions ...or some tricky race condition bug?
> 
> Thanks,
> Michael
> 
> -- 
> Michael Balzer * Paradestr. 8 * D-42107 Wuppertal
> Fon 0202 / 272 2201 * Handy 0176 / 206 989 26
> 
> <dexter.vcf>_______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev




More information about the OvmsDev mailing list