[Ovmsdev] Think City EV

[Mark Webb-Johnson]

Nikolay,

OK. The can reverse engineer messages you showed me the other day look good. I think with the roadster and twizy code, you should have a good idea of what is required.

Have fun, and let us know if there is anything you need.

Regards, Mark.

On 31 Dec, 2012, at 3:38 PM, Nikolay Shishkov wrote:

> Yes, I already cloned the repository (so I don't disturb anyone else's work) and have started working out if I want to scale down the twizy code or scale up the roadster one. 
> I know all the CAN ids needed and their format and I hope to have something that I can test within the next few days.
> Thanks,
> Nikolay
> 
> From: Mark Webb-Johnson <mark at webb-johnson.net>
> To: OVMS Developers <ovmsdev at lists.teslaclub.hk> 
> Sent: Monday, December 31, 2012 3:42 AM
> Subject: Re: [Ovmsdev] Think City EV
> 
> Nikolay,
> 
> I can't remember if I said this before, but this is all done. The stub is in place and is for vehicle type "TC".
> 
> When reporting the vehicle type, the last two digits can be set dynamically in the module itself.
> 
> Regards, Mark.
> 
> On 28 Dec, 2012, at 3:11 PM, Nikolay Shishkov wrote:
> 
>> Sounds good. Maybe the VIN number idea would work nicely.
>> Since I have access to a Think with a Zebra battery I would like to start with that. 
>> Can we make the vehicle id TCZB, the enerdel Think is ok with the TCEL.
>> Thanks,
>> Nikolay
>> 
>> 
>> From: Mark Webb-Johnson <mark at webb-johnson.net>
>> To: OVMS Developers <ovmsdev at lists.teslaclub.hk> 
>> Sent: Friday, December 28, 2012 3:28 AM
>> Subject: Re: [Ovmsdev] Think City EV
>> 
>> 
>> If the cars have some messages in common, then best to use one module for both and switch the vehicle type either specifically in config (carbits) or dynamically at runtime (by looking at the messages). That is the way we handled the differences between v1 and v2 Tesla Roadsters. For the roadster, we looked at the VIN message, and automatically switch v1 or v2 support based on the vehicle type identified by the VIN.
>> 
>> In that case, I think vehicle_thinkcity.* is fine, but vehicle id TCMS and TCEL would differentiate the two. The vehicle module identified can simply be "TC". The vehicle type is a variable in memory, and purely informative.
>> 
>> Let's try it that way to start, but if the modules really differ too much then we can split later. Perhaps start with just one variant?
>> 
>> Regards, Mark.
>> 
>> On 28 Dec, 2012, at 9:57 AM, Nikolay Shishkov wrote:
>> 
>>> Thanks Mark, 
>>> 
>>> I may need two stubs - one for the model with Zebra (molten salt) batteries, and the other one for the enerdel li-ion batteries.
>>> They have different battery systems with different can bus messages, and I think it may be easier to have the code separate?
>>> Most of the other systems are the same...so some kind of inheritance or common stub maybe more appropriate?
>>> 
>>> Nikolay
>>> 
>>> From: Mark Webb-Johnson <mark at webb-johnson.net>
>>> To: OVMS Developers <ovmsdev at lists.teslaclub.hk> 
>>> Sent: Friday, December 28, 2012 1:47 AM
>>> Subject: [Ovmsdev] Think City EV
>>> 
>>> 
>>> Nikolay,
>>> 
>>> I'll create the stub vehicle code for Think City EV for you.
>>> 
>>> We'll need a vehicle name and ID. I suggest:
>>> 
>>> Module:		vehicle_thinkcity.*
>>> ID:			TCEV
>>> 
>>> Is that ok? If so, I'll create it today.
>>> 
>>> Regards, Mark.
>>> 
>>> 
>>> _______________________________________________
>>> OvmsDev mailing list
>>> OvmsDev at lists.teslaclub.hk
>>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>>> 
>>> 
>>> _______________________________________________
>>> OvmsDev mailing list
>>> OvmsDev at lists.teslaclub.hk
>>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>> 
>> 
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.teslaclub.hk
>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>> 
>> 
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.teslaclub.hk
>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
> 
> 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
> 
> 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20121231/7aeb3af6/attachment.htm>